feat: add speaker names and URL next to their talks #338
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
This comment was marked as resolved.
This comment was marked as resolved.
astorije
force-pushed
the
astorije/talk-authors
branch
from
aa3abc2
to
4746b82
Compare
app/components/UnorderedList.css.ts
Outdated
There was a problem hiding this comment.
[Non-Actionable] Heh, I hadn't thought to do this before... this strikes me as a little confusing but I don't know of a better way to reuse the styles. vanilla-extract-css/vanilla-extract#726 has some notes but nothing super relevant. 🤷 no change requests from me.
There was a problem hiding this comment.
I'm super open to doing this differently if you have another way to suggest!
PR Checklist
status: accepting prsOverview
I do not have all the speaker URLs at this time, but that doesn't need to block the PR or its review, I can add the missing ones later on.