Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derek/clk downloads #144

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Derek/clk downloads #144

merged 9 commits into from
Jan 10, 2024

Conversation

betaBison
Copy link
Member

Expands file download options to enable downloads for:

  • rinex_nav: present - Jan 1, 2013
  • sp3 : present - May 24, 2012
  • clk : present - Oct 14, 2012
    Also adds secondary sources for WUM0MGXFIN clk, wum clk, and BRDM00DLR_R rinex nav for outlier days when those files weren't uploaded to CDDIS

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ea032c) 99.62% compared to head (2e1e64e) 99.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           v0.2.3     #144      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files          21       21              
  Lines        3427     3545     +118     
==========================================
+ Hits         3414     3532     +118     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@betaBison
Copy link
Member Author

All downloads were successful on my machine between May 25, 2013 and Nov 6, 2023

Copy link
Member

@danineamati danineamati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few notes where the comments do not quite match the code. I liked that the order of events in the documentation nicely parallels the code and the tests. The tests check all the relevant date ranges supported in the new branch.

@betaBison betaBison removed the request for review from kanhereashwin January 10, 2024 18:10
Copy link
Member

@danineamati danineamati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All feedback addressed!

@betaBison betaBison merged commit 35445af into v0.2.3 Jan 10, 2024
12 checks passed
@betaBison betaBison deleted the derek/clk-downloads branch January 10, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants