-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derek/clk downloads #144
Derek/clk downloads #144
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.2.3 #144 +/- ##
==========================================
+ Coverage 99.62% 99.63% +0.01%
==========================================
Files 21 21
Lines 3427 3545 +118
==========================================
+ Hits 3414 3532 +118
Misses 13 13 ☔ View full report in Codecov by Sentry. |
All downloads were successful on my machine between May 25, 2013 and Nov 6, 2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few notes where the comments do not quite match the code. I liked that the order of events in the documentation nicely parallels the code and the tests. The tests check all the relevant date ranges supported in the new branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All feedback addressed!
Expands file download options to enable downloads for:
rinex_nav
: present - Jan 1, 2013sp3
: present - May 24, 2012clk
: present - Oct 14, 2012Also adds secondary sources for
WUM0MGXFIN
clk,wum
clk, andBRDM00DLR_R
rinex nav for outlier days when those files weren't uploaded to CDDIS