Fix localization of poor quality weapon

Apply poor quality weapon modifier to NPC rolls Signed-off-by: Marcloure <[email protected]>
StasTserk · Oct 20, 2024 · 10d7e1e · 10d7e1e
1 parent 406afe2
commit 10d7e1e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/module/rolls/npcSkillRoll.ts b/module/rolls/npcSkillRoll.ts
@@ -15,6 +15,7 @@ import {
     getSplitPoolText,
     getSplitPoolRoll,
     NpcEventHandlerOptions,
+    mergePartials,
 } from './rolls';
 import { byName, notifyError } from '../helpers';
 import { Npc } from '../actors/Npc';
@@ -68,6 +69,34 @@ export async function handleNpcWeaponRoll({
             'The weapon that is being cast appears to be missing from the character sheet.'
         );
     }
+
+    const quality = (weapon as MeleeWeapon | RangedWeapon).system.quality;
+
+    let weaponPreset: Partial<RollDialogData> = {};
+    if (quality === 'superior') {
+        weaponPreset = {
+            diceModifiers: [
+                {
+                    dice: 1,
+                    label: game.i18n.localize('BW.weapon.superiorQuality'),
+                    optional: false,
+                },
+            ],
+        };
+    } else if (quality === 'poor') {
+        weaponPreset = {
+            obModifiers: [
+                {
+                    obstacle: 1,
+                    label: game.i18n.localize('BW.weapon.poorQuality'),
+                    optional: false,
+                },
+            ],
+        };
+    }
+
+    dataPreset = mergePartials(weaponPreset, dataPreset);
+
     const extraInfo =
         weapon.type === 'melee weapon'
             ? await (weapon as MeleeWeapon).getWeaponMessageData(

diff --git a/module/rolls/rollWeapon.ts b/module/rolls/rollWeapon.ts
@@ -77,7 +77,7 @@ export async function handleWeaponRoll({
             obModifiers: [
                 {
                     obstacle: 1,
-                    label: game.i18n.localize('BW.weapon.superiorQuality'),
+                    label: game.i18n.localize('BW.weapon.poorQuality'),
                     optional: false,
                 },
             ],