Ros2 minimal add kr16 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When we merge rolling, then please take care of this Manuel's KR 16 version |
destogl
force-pushed
the
ros2-minimal
branch
from
a6cfaca to
726d0a4
Compare
muritane
force-pushed
the
ros2-minimal-add-kr16
branch
from
9f9ba64 to
7e6b556
Compare
muritane
force-pushed
the
ros2-minimal-add-kr16
branch
from
7e6b556 to
ff042a7
Compare
destogl
reviewed
Mar 27, 2023
kuka_kr16_support/CMakeLists.txt
Outdated
There was a problem hiding this comment.
This file should be reverted to the version as it was. Except the roslauch_test. But the test we will probably have to in another PR. We need to launch tests as they are done in UR repository.
There was a problem hiding this comment.
is this needed, or functionality is already there, but configuration in another file?
There was a problem hiding this comment.
Isn't this file also already in the repository?
There was a problem hiding this comment.
I mean from the functionality perspective?
| <test_depend>roslaunch</test_depend> | ||
|
|
||
| <exec_depend>industrial_robot_client</exec_depend> | ||
| <exec_depend>joint_state_publisher</exec_depend> |
| <exec_depend>kuka_resources</exec_depend> | ||
| <exec_depend>robot_state_publisher</exec_depend> | ||
| <exec_depend>rviz</exec_depend> | ||
| <exec_depend>xacro</exec_depend> |
| <exec_depend>kuka_resources</exec_depend> | ||
| <exec_depend>robot_state_publisher</exec_depend> | ||
| <exec_depend>rviz</exec_depend> |
| @@ -1,13 +1,6 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
This should also be replaced with the PR #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.