Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/fp 1652 template inheritance #142

Closed
wants to merge 12 commits into from
Closed

Bugfix/fp 1652 template inheritance #142

wants to merge 12 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 23, 2022 •
edited
Loading

Overview

  • To simplify app installation.
  • To deprecate hacked paths (many) for templates.
  • To add proper paths (few) for templates.

Related

Changes

  1. [docs] update templates README
  2. [warning] import settings and settings_local⚠️
  3. [enhancement] (texascale, ecep) simplify INSTALLED_APPS
  4. [enhancement] use variable for path to Core
  5. [enhancement] simplify CMS_TEMPLATES
  6. [chore] deprecate "old way" template paths
  7. [fix] update extends paths

⚠️ This change is required by TACC/Core-CMS#492, which loads settings_custom by default.

Testing / Screenshots / Notes

See TACC/Core-CMS#492.

wesleyboar added 12 commits May 12, 2022 12:18
@wesleyboar
wip-feat(fp-1487): pythonic app template load
2c3a332
@wesleyboar
feat(fp-1652)!: correctly extend core templates
dc2054f 
- install blog apps at end of list (simpler)
- load settings at top of settings_custom, bot middle
- fix template inheritence (texascale, ecep)

BREAKING CHANGE: template inheritence now incompatible with main
@wesleyboar
fix(fp-1652): load settings_local (cuz core don't)
fbe4c80
@wesleyboar
chore(fp-1652): simpler isntalled_apps extend
cbe1130
@wesleyboar
chore(fp-1652): simpler CMS_TEMPLATES extend
38067e8
@wesleyboar
chore(fp-1652): a2cps: deprecate old tmpl paths
1bd360c 
Requires: TACC/Core-CMS#da85200
@wesleyboar
chore(fp-1652): frontera: deprecate old templates
4fab5f8 
Requires: TACC/Core-CMS#da85200
@wesleyboar
chore(fp-1652): import settings & settings_local
a4f2369 
required since Core change made settings_custom be loaded as base
@wesleyboar
chore(fp-1652): 3dem: deprecate old templates
fbb7def 
Requires: TACC/Core-CMS#da85200
@wesleyboar
chore(fp-1652): protx: deprecate old templates
029db57 
Requires: TACC/Core-CMS#da85200
@wesleyboar
chore(fp-1652): texascale: deprecate old templates
4238220 
Requires: TACC/Core-CMS#da85200
@wesleyboar
chore(fp-1652): utrc: cleanup template deprecation
79a005d
This was referenced May 23, 2022
Closed
Closed
@wesleyboar
Copy link
Member Author

wesleyboar commented Sep 1, 2023 •
edited
Loading

Abandoned because this is so out-of-date (many merge conflicts) and because https://github.com/TACC/Core-CMS-Custom relies on overwriting templates. Rather than fight that in favor of template inheritance (which I have failed to make work for three years), I abandon template inheritance.

@wesleyboar wesleyboar closed this Sep 1, 2023
@wesleyboar wesleyboar deleted the bugfix/fp-1652-template-inheritance branch November 13, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar