-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fp 1652 template load order #492
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor template dir load order - default to load settings_custom, not settings - load installed apps in appropriate location - fix template inheritence (core: blog) - fix template inheritence (texascale, ecep) Caveat: project defined manually (env var not available yet) BREAKING CHANGE: load settings_custom by default, not settings
core stopped loading it, so custom projects must this is not a desirable change; expect revisit
- new settings management - deprecate some old templates (more to deprecate in future commits)
Merged
Abandoned because this is so out-of-date (many merge conflicts) and because https://github.com/TACC/Core-CMS-Custom relies on overwriting templates. Rather than fight that in favor of template inheritance (which I have failed to make work for three years), I abandon template inheritance. |
Replaced by #710. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
settings_custom
.Overview
To install apps and load templates the order Django CMS expects:
Related
Changes
settings_custom
instead ofsettings
settings_local
templates/README
settings_custom
to run CMS. I may be able to revert this change safely, because it may have been a part a fix that is actually not necessary.Testing
Screenshots
…
Notes
The annual benefit (minor) is to support custom Texascale blog styles each year.
This is a small part of FP-1439.
The occasional benefit (convenience) is overriding a Core template without editing
settings_custom
.This is performed here via TACC/Core-CMS-Resources#142.
The onboarding benefit (standardization) is relying on Django template inheritance.
The previous template customization method was template replacement.