Skip to content

Commit

Permalink
chore: move favicon markup to core assets
Browse files Browse the repository at this point in the history
In assets_custom, it was copied by CMS in Core-CMS-Custom and tup-ui.

Stop copying. No one ever changes it. Settings do that. Let Core lead.
  • Loading branch information
wesleyboar committed Aug 29, 2023
1 parent 9e892c6 commit 4086324
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
4 changes: 4 additions & 0 deletions taccsite_cms/templates/assets_core.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@
@import url("https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css") layer(foundation);
@import url("{% static 'site_cms/css/build/core-styles.base.css' %}") layer(base);
</style>

{% with settings.FAVICON as favicon %}
<link rel="icon" href="{% static favicon.img_file_src %}" type="image/x-icon" />
{% endwith %}
9 changes: 0 additions & 9 deletions taccsite_cms/templates/assets_custom.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
{% load static %}

{# Load assets as external files, to cache independently of markup. #}
{% comment %}
FAQ: IF a script or style is better cached with markup, THEN:
Expand All @@ -11,13 +9,6 @@



<!-- Custom Site Assets: Favicon. -->
{% with settings.FAVICON as favicon %}
<link rel="icon" href="{% static favicon.img_file_src %}" type="image/x-icon" />
{% endwith %}



{# Do NOT directly load project-specific assets here; see `/taccsite_custom` #}

{# Example #}
Expand Down

0 comments on commit 4086324

Please sign in to comment.