Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip-feat(fp-1487): pythonic app template load #487

Closed

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 12, 2022

Overview

Make template overwrites not require adding new entry to CMS_TEMPLATES.

Related

Changes

  • abstract the function that gets CMS app names from file system
  • update documentation
  • in TEMPLATES, replace loaders with 'APP_DIRS': True

Testing

Screenshots

Notes

This didn't work. I thought it was easy. Guess not. This PR is for reference.

@wesleyboar
Copy link
Member Author

Loading Frontera templates via deprecated paths worked fine. But loading Frontera templates via new short paths (that should look in taccsite_custom first) failed—it loaded Core template instead. When I mucked with DIRS, I got a new error about maximum recursion when importing a static file in one of the templates. I believe TEMPLATE_DIRS settings affects more than just CMS_TEMPLATES path resolution, and my ignorance of the details is what is causing the failures.

@wesleyboar wesleyboar closed this May 12, 2022
@wesleyboar
Copy link
Member Author

Replaced by #710.

@wesleyboar wesleyboar deleted the task/FP-1487-cms-projects-as-apps--template-repair branch November 13, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant