enhance: support template overwrite not inheritance #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
added a commit
to TACC/Core-CMS-Resources
that referenced
this pull request
Aug 29, 2023
There is no reason to do this on every template. I had continued doing it, because I feared breaking things. I know enough about the templates now to know repition was unnecessary.
wesleyboar
force-pushed
the
enhance/clean-up-templates
branch
from
587dad1 to
9e892c6
Compare
In assets_custom, it was copied by CMS in Core-CMS-Custom and tup-ui. Stop copying. No one ever changes it. Settings do that. Let Core lead.
wesleyboar
force-pushed
the
enhance/clean-up-templates
branch
from
a40fbde to
4086324
Compare
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Clean up templates in a way that supports https://github.com/TACC/Core-CMS-Custom and https://github.com/TACC/tup-ui overwrites of them.
Related
Testing & UI
{% block assets_… %}.See:
Changes
assets_customtoassets_coreassets_customof how to customize fontspage_titletobase(so no need to mass duplicate)