-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/FP-1886: Remove My Account from pulldown at the top right #723
Conversation
…eAccount setting is True
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 67.12% 67.12%
=======================================
Files 430 430
Lines 13545 13545
Branches 2519 2519
=======================================
Hits 9092 9092
Misses 4163 4163
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not approved only because I have not tested. I'll be back.
Were I to solve this via Portal, this is exactly how I would solve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
Hiding the "My Accounts" button in the nav drop-down if the hideManageAccount setting is True
Related
Changes
If the
WORKBENCH_SETTINGS
booleanhideManageAccount
is set to true, it will now hide the "My Accounts" button in the top-right drop down nav. This means thatWORKBENCH_SETTINGS
is now passed to this Django template as a context variable.Testing
settings_custom.py
file, make surehideManageAccount
is set toTrue
in the_WORKBENCH_SETTINGS
dictionaryhideManageAccount
toFalse
UI
Notes