Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/FP-1886: Remove My Account from pulldown at the top right #723

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

fnets
Copy link
Contributor

@fnets fnets commented Oct 20, 2022

Overview

Hiding the "My Accounts" button in the nav drop-down if the hideManageAccount setting is True

Related

Changes

If the WORKBENCH_SETTINGS boolean hideManageAccount is set to true, it will now hide the "My Accounts" button in the top-right drop down nav. This means that WORKBENCH_SETTINGS is now passed to this Django template as a context variable.

Testing

  1. In the settings_custom.py file, make sure hideManageAccount is set to True in the _WORKBENCH_SETTINGS dictionary
  2. Navigate to any page in portal, and check if the "My Account" button is available under the top-right nav dropdown. It should be hidden. (See UI below)
  3. Set hideManageAccount to False
  4. The "My Account" button should now be available under the top-right nav dropdown.

UI

Screen Shot 2022-10-20 at 5 08 03 PM

Notes

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #723 (02bfdd1) into main (2e9ca7c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   67.12%   67.12%           
=======================================
  Files         430      430           
  Lines       13545    13545           
  Branches     2519     2519           
=======================================
  Hits         9092     9092           
  Misses       4163     4163           
  Partials      290      290           
Flag Coverage Δ
javascript 68.58% <ø> (ø)
unittests 65.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/portal/settings/settings.py 0.00% <ø> (ø)

Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not approved only because I have not tested. I'll be back.

Were I to solve this via Portal, this is exactly how I would solve it.

Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rstijerina rstijerina merged commit e01b094 into main Oct 24, 2022
@rstijerina rstijerina deleted the task/FP-1886 branch October 24, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants