feat(tup-cms): tup-348 portal nav #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
commented
Oct 21, 2022
apps/tup-cms/src/apps/portal_nav/templates/portal_nav/nav_portal.raw.html
Show resolved
Hide resolved
| @@ -1,5 +1,6 @@ | |||
| from django.urls import path, include | |||
|
|
|||
| custom_urls = [ | |||
| path('core/markup/nav/', include('apps.portal_nav.urls', namespace='portal_nav')), | |||
There was a problem hiding this comment.
apps/tup-cms/src/apps/portal_nav/templates/portal_nav/nav_portal.raw.html
Show resolved
Hide resolved
jarosenb
reviewed
Nov 2, 2022
The `nx format:write` is braking django HTML single-line comments into multi-line comments 😠.
Since 28dd2f0, single-line commits will not be broken by nx format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support Portal nav in TUP. Basically, mirror Core Portal's.
Related
Changes
Testing
Setup
Run Portal & CMS:
npx nx run tup-ui:servecd apps/tup-cmsdocker-compose -f docker-compose.dev.yml build --no-cachedocker-compose -f docker-compose.dev.yml up --force-recreateTest
Known Issues:
4. Form has font issues. No ticket.
4. Form has no responsiveness. No ticket.
6. 8. No icons when user is logged in. No ticket.
10. Initial log out does not log user out of CMS. No ticket.
10. Initial log out does not update header. (Why not?) No ticket.
UI
status
known issue
logged out
logged out
logged in
logged out
portal nav bug
logged out
cms admin bug