-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:News alerts #219
Merged
Merged
feat:News alerts #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
chore/news-testing
branch
from
September 12, 2023 20:57
e135cd8
to
81e2307
Compare
CommanderStorm
force-pushed
the
feat/news-alerts
branch
2 times, most recently
from
September 12, 2023 23:17
94399ca
to
bbc0172
Compare
CommanderStorm
force-pushed
the
feat/news-alerts
branch
from
September 13, 2023 20:37
4d2f2a5
to
99dae4c
Compare
CommanderStorm
force-pushed
the
feat/news-alerts
branch
from
September 13, 2023 22:10
419f9fa
to
6702ad0
Compare
# Conflicts: # server/api/generate.sh # server/api/tumdev/campus_backend.pb.go # server/backend/newsAlerts_test.go
# Conflicts: # server/backend/news_test.go
kordianbruck
requested changes
Sep 18, 2023
# Conflicts: # server/api/tumdev/campus_backend.pb.go # server/api/tumdev/campus_backend.proto # server/api/tumdev/campus_backend.swagger.json
Merged
# Conflicts: # server/api/tumdev/campus_backend.pb.go # server/api/tumdev/campus_backend.pb.gw.go # server/api/tumdev/campus_backend.proto # server/api/tumdev/campus_backend.swagger.json # server/api/tumdev/campus_backend_grpc.pb.go # server/backend/newsAlerts.go
# Conflicts: # server/api/tumdev/campus_backend.pb.go # server/backend/newsAlerts.go # server/backend/news_test.go
kordianbruck
approved these changes
Oct 1, 2023
Awesome 🍻 |
# Conflicts: # client/go.mod # client/go.sum # server/api/tumdev/campus_backend.pb.go # server/api/tumdev/campus_backend.swagger.json # server/backend/news_alerts.go # server/backend/news_alerts_test.go # server/backend/news_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the news alert apis (
GetNewsAlerts
,GetNewsAlert
) and RenamesGetTopNews
->GetTopNewsAlert