Add feature: audio normalization during transcoding #1230
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Reason for this feature: #1206
With the new feature, this problem can be avoided: #1186
Description
Applies the loudnorm filter of ffmpeg during transcoding. Parameters are chosen according to the EBU recommendation R128.
Results of some experiments with this method
Steps for Testing
Prerequisites:
StreamContext
with only one member variabletranscodingCmd: *exec.Cmd
;StreamContext.getStreamName(void): string
by returning any string (will be used in log information);StreamContext.getRecordingFileName(void): string
by returning the directory of the video to test;StreamContext.getTranscodingFileName(void): string
by returning the directory of the output video (with a proper file extension, such as .mp4)sc
, of the mocked typeStreamContext
, withtranscodingCmd = nil
transcode(streamCtx: *StreamContext): error
with the parameter&sc