Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/runner audio normalization #1329

Merged
merged 9 commits into from
May 13, 2024

Conversation

YiranDuan721
Copy link
Contributor

Motivation and Context

Previous PR: #1230
As mentioned in #1206: The range of the volume varies across the recordings, which leads to a poorer user experience in some cases, and has caused problem to the silence-skip feature.

Description

As discribed in #1230:
Applies the loudnorm filter of ffmpeg during transcoding. Parameters are chosen according to the EBU recommendation R128.

Results of some experiments with this method, from here:

Normalization using the loudnorm filter in FFmpeg has achieved good results: The graphs below show the changes in volume over time for three video recordings, comparing the original version to the normalized version. The stashed red line marks -15dB, which is now used as the threshold for silence detecting -- and is indeed suitable for the normalized audio, according to the result to these experiments.


The three recordings, after audio normalization, all sound good to me. The volume scatter points in the graph represent the maximum volume of a serial of segments (lasting from 3 to 8.333333 seconds), obtained by the ffmpeg volumedetect filter.

Steps for Testing

Further tests can be done with the test of the runner.

@DawinYurtseven DawinYurtseven merged commit 9eecbae into enh/runner May 13, 2024
@DawinYurtseven DawinYurtseven deleted the enh/runner-audio-normalization branch May 13, 2024 12:53
@CommanderStorm
Copy link
Member

@YiranDuan721 (sorry for the ping)

Did this PR resolve the following issues?

@YiranDuan721
Copy link
Contributor Author

YiranDuan721 commented Oct 24, 2024

@YiranDuan721 (sorry for the ping)

Anytime!

Did this PR resolve the following issues?

It is supposed to have solved #1206, and to be helpful for #1186 in most cases. However, I haven't had time to do more tests on it. I would suggest that more tests should be done for the changes, e.g. transcode some problematic videos with the changes and see if the Pausen can be detected as expected. Saddly, it seems that I myself won't have time to work on it in this semester.

@MariusAlbrecht
Copy link

MariusAlbrecht commented Dec 29, 2024

the behaviour originally described in #1186 seems to still be as is. In other words: the entirety of https://live.rbg.tum.de/w/sturepfuprover/35614 is still being recognized as one whole skippable section.

@CommanderStorm

@joschahenningsen
Copy link
Member

this pr was merged into the enh/runner branch, which is an attempt to replace the currently rather unreliable worker. This unfortunately remains work in progress and I have no estimate about the eta. Right now the project is on @DawinYurtseven s plante

@MariusAlbrecht
Copy link

No problem! I was just going through my open issues to see if any are wrongfully open and then went ahead and answered @/CommanderStorm's question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants