-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/runner audio normalization #1329
Conversation
…tly 1 video exists for the stream.
…make sure to close everything in case of error
@YiranDuan721 (sorry for the ping) Did this PR resolve the following issues? |
Anytime!
It is supposed to have solved #1206, and to be helpful for #1186 in most cases. However, I haven't had time to do more tests on it. I would suggest that more tests should be done for the changes, e.g. transcode some problematic videos with the changes and see if the Pausen can be detected as expected. Saddly, it seems that I myself won't have time to work on it in this semester. |
the behaviour originally described in #1186 seems to still be as is. In other words: the entirety of https://live.rbg.tum.de/w/sturepfuprover/35614 is still being recognized as one whole skippable section. |
this pr was merged into the enh/runner branch, which is an attempt to replace the currently rather unreliable worker. This unfortunately remains work in progress and I have no estimate about the eta. Right now the project is on @DawinYurtseven s plante |
No problem! I was just going through my open issues to see if any are wrongfully open and then went ahead and answered @/CommanderStorm's question. |
Motivation and Context
Previous PR: #1230
As mentioned in #1206: The range of the volume varies across the recordings, which leads to a poorer user experience in some cases, and has caused problem to the silence-skip feature.
Description
As discribed in #1230:
Applies the loudnorm filter of ffmpeg during transcoding. Parameters are chosen according to the EBU recommendation R128.
Results of some experiments with this method, from here:
Steps for Testing
Further tests can be done with the test of the runner.