-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
popup chat close on esc added. #1281
Conversation
Your Testserver will be ready at https://1281.test.live.mm.rbg.tum.de in a few minutes. Logins
|
I think that this is a convenient feature. 👍 But we should document that shortcut somewhere, right? Maybe we could have a couple other shortcuts here which are then explained in a small dialog box. I imagine a small icon with a keyboard logo. It could be a component that we could reuse on other parts of the website where we use shortcuts. |
Maybe one other note. Commit messages should not end with a dot ( |
While implementing that I was also asking myself how will user gonna know that popup chat can be closed by pressing esc but could not think of a convenient idea. I think your suggestion makes sense. If its ok for you, I can create a new issue about it and work on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
* popup chat close on esc added. * Update popup-chat.gohtml --------- Co-authored-by: Sebastian <[email protected]>
* Added list view -> not finished yet * Enh/transcoding issues (#1283) * added boolean to commandBuild and lowered probesize a bit to see if it works now * Removed checks for isSelfStream because not used * Removed deprecated for isSelfStream * Set isSelfStream to true for selfstreams * added boolean to commandBuild and lowered probesize a bit to see if it works now --------- Co-authored-by: Dawin Yurtseven <[email protected]> * popup chat close on esc added. (#1281) * popup chat close on esc added. * Update popup-chat.gohtml --------- Co-authored-by: Sebastian <[email protected]> * Set GIN to only log above level 400 (#1271) * Show worker version on worker dashboard (#1285) * Updated storage * Lint fix * Update course.ts changed if else writing style * Lint fix --------- Co-authored-by: Dawin Yurtseven <[email protected]> Co-authored-by: barisgul15 <[email protected]> Co-authored-by: Dawin <[email protected]>
* popup chat close on esc added. * Update popup-chat.gohtml --------- Co-authored-by: Sebastian <[email protected]>
* Added list view -> not finished yet * Enh/transcoding issues (#1283) * added boolean to commandBuild and lowered probesize a bit to see if it works now * Removed checks for isSelfStream because not used * Removed deprecated for isSelfStream * Set isSelfStream to true for selfstreams * added boolean to commandBuild and lowered probesize a bit to see if it works now --------- Co-authored-by: Dawin Yurtseven <[email protected]> * popup chat close on esc added. (#1281) * popup chat close on esc added. * Update popup-chat.gohtml --------- Co-authored-by: Sebastian <[email protected]> * Set GIN to only log above level 400 (#1271) * Show worker version on worker dashboard (#1285) * Updated storage * Lint fix * Update course.ts changed if else writing style * Lint fix --------- Co-authored-by: Dawin Yurtseven <[email protected]> Co-authored-by: barisgul15 <[email protected]> Co-authored-by: Dawin <[email protected]>
Motivation and Context
closes #1280
Description
add an event listener so that popup chat is closed when esc is clicked
Steps for Testing
Prerequisites:
Screenshots