Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Golangci-lint errors #1361

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Fix Golangci-lint errors #1361

merged 12 commits into from
Jun 14, 2024

Conversation

SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Jun 12, 2024

Motivation and Context

This PR should fix the Issues with the golangci

@SebiWrn SebiWrn self-assigned this Jun 12, 2024
Copy link

Your Testserver will be ready at https://1361.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@SebiWrn
Copy link
Collaborator Author

SebiWrn commented Jun 13, 2024

golangci-lint now working on github. Issue was that there was no node_modules folder, but the go router referenced it with a //go:embed link. Golangci-lint now first installs all node packages, which creates the node_modules folder and then tests with the linters.

@SebiWrn SebiWrn changed the title Change to create PR Fix Golangci-lint errors Jun 13, 2024
@SebiWrn SebiWrn enabled auto-merge (squash) June 13, 2024 12:09
Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🍻

@SebiWrn SebiWrn merged commit d7af081 into dev Jun 14, 2024
8 checks passed
@SebiWrn SebiWrn deleted the fix/fix-golangci branch June 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants