Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Box to search for courses, streams and subtitles #1380

Merged
merged 118 commits into from
Nov 26, 2024
Merged

Conversation

SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Sep 20, 2024

Motivation and Context

This Change solves the problem of finding lectures in a large list of lectures. It also enhances the search for subtitles or streams in courses.
Closes #1337.

Description

The change adds a search bar at the top of every page where you can search for courses or contents of a course, depending if you're on a course page or on the home page.

Steps for Testing

You can't test this change on the Testserver system.

You have to set up your own local instance of TUM-Live for testing and also have to setup your own meilisearch service.
To start the meilisearch service, you can run the following command:

docker run -it --rm \
    -p 7700:7700 \
    -e MEILI_MASTER_KEY='MASTER_KEY'\
    -v $(pwd)/meili_data:/meili_data \
    getmeili/meilisearch:v1.9 \
    meilisearch --env="development"

If the data isn't automatically exported to meilisearch, you can run this job from the Maintenance Tab in the Admin panel.

You can enter your search query in the search bar on every page or you can press 'Enter' while the search bar is focused to see the full search page with filters etc.

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you were likely not expecting a review from me, but @joschahenningsen told me that meilisearch is happening and I thought that looking over the usage might be benefitial.

This is an incredibly large PR.
Reviewing this is impossible, anybody who tells you that they reviewed it is likely lying on at least some part.

=> Please in the future split your PRs way before the +2,513 lines mark.

tools/meiliSearch.go Show resolved Hide resolved
tools/meiliExporter.go Outdated Show resolved Hide resolved
tools/meiliExporter.go Outdated Show resolved Hide resolved
web/ts/search.ts Outdated Show resolved Hide resolved
api/search.go Show resolved Hide resolved
dao/courses.go Outdated Show resolved Hide resolved
dao/courses.go Outdated Show resolved Hide resolved
model/semester.go Outdated Show resolved Hide resolved
model/semester.go Outdated Show resolved Hide resolved
api/search.go Show resolved Hide resolved
tools/meiliExporter.go Outdated Show resolved Hide resolved
dao/streams.go Outdated Show resolved Hide resolved
@CommanderStorm
Copy link
Member

From my point of view, there is nothing left to review.
There are a few threads (like #1380 (comment)) which are not quite resolved, but from my point nothing blocks merging.

@SebiWrn SebiWrn requested a review from karjo24 October 21, 2024 15:10
@karjo24
Copy link
Contributor

karjo24 commented Oct 24, 2024

From my point of view, there is nothing left to review.

@CommanderStorm Thanks for your review and suggestions, it was much appreciated! :)

@SebiWrn SebiWrn dismissed CommanderStorm’s stale review November 24, 2024 12:53

Text message approves PR but request changes not removed

@SebiWrn SebiWrn merged commit f721791 into dev Nov 26, 2024
8 checks passed
@SebiWrn SebiWrn deleted the enh/search-box-ui branch November 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search box in "My Courses" and "Public Courses"
6 participants