Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/add runner workflow #1390

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Enh/add runner workflow #1390

merged 2 commits into from
Oct 23, 2024

Conversation

SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Oct 22, 2024

Adds a new workflow the the github workflows so runners from the beta branch can be deployed

Copy link

Your Testserver will be ready at https://1390.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have provided some enhancement proposals but no bugs/.. ^^

Comment on lines +23 to +25
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's use checkout@v4 and
  • add a comment wat this ref is for (I'd assume this or something equivalent should be the default, right?)

id: vars
run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
- name: Build and push Docker images (${{ matrix.module }})
uses: docker/build-push-action@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to configure sbom and build provence here.
Example how I did this:
https://github.com/TUM-Dev/NavigaTUM/blob/main/.github/workflows/_docker-build.yml

(This does not have an immediate impact but allows more forensics for some attack scenarios for little to no maintenance-effort as far as I read up on)

push: true
build-args: version=${{ github.ref_name }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to configure cache-from and related parameters.
Here is an example how to do this: https://docs.docker.com/build/ci/github-actions/cache/#cache-mounts

Likely the builds are already really fast (looking at you, rust), but a few seconds for a few lines...

@SebiWrn
Copy link
Collaborator Author

SebiWrn commented Oct 23, 2024

Thank you for the feedback, I think I'll deploy it anyway so we can deploy the beta system as fast as possible, but I'll keep your feedback in mind and open another PR for these changes so I can also change this on the current workers and tumlive deployment actions.

@SebiWrn SebiWrn merged commit 9945687 into dev Oct 23, 2024
8 of 9 checks passed
@SebiWrn SebiWrn deleted the enh/add-runner-workflow branch October 23, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants