Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shuffleboard entries global pointers in port #26

Closed
jkleiber opened this issue Dec 30, 2022 · 0 comments
Closed

Make shuffleboard entries global pointers in port #26

jkleiber opened this issue Dec 30, 2022 · 0 comments
Assignees

Comments

@jkleiber
Copy link
Contributor

jkleiber commented Dec 30, 2022

Summary
Using global references (using extern) for the shuffleboard stuff was working great in beta3. Now in beta7, they've switched to using pointers for some reason, and we need to change to pointers in order for the code to compile.

The argument can be made that we should not be doing what we are currently doing (storing references to shuffleboard variables globally), but this pattern is driven by the WPILib's setup. We can reconsider our decisions in another ticket, and fix the code quickly in this one so we can build code on beta7

Work to Do

  • Switch global references to global pointers

Verification

  • CI passes

Deferred work
-#28: Maintain the shuffleboard pointers in software subsystems

FYI @danielbrownmsm

@jkleiber jkleiber added this to the Previous Functionality milestone Dec 30, 2022
@jkleiber jkleiber self-assigned this Dec 30, 2022
jkleiber added a commit that referenced this issue Dec 30, 2022
…references. Need to add nullptr checking or something
jkleiber added a commit that referenced this issue Jan 2, 2023
* #26: fixes the shuffleboard values to be global pointers rather than references. Need to add nullptr checking or something

* #26: pushing the build.gradle update in order to fix CI
@jkleiber jkleiber closed this as completed Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant