Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Shuffleboard pointers in individual software subsystems #28

Open
jkleiber opened this issue Jan 2, 2023 · 0 comments
Open

Manage Shuffleboard pointers in individual software subsystems #28

jkleiber opened this issue Jan 2, 2023 · 0 comments
Labels
starter ticket Good for newcomers

Comments

@jkleiber
Copy link
Contributor

jkleiber commented Jan 2, 2023

Summary
When the WPILib updated Shuffleboard to return pointers in GetEntry(), our anti-pattern of managing global references no longer made sense. In #26 , we ported the references to pointers to maintain compatibility, but it would be better to track our shuffleboard widgets in the software subsystems instead of globally.

Work to Do

  • Move shuffleboard pointers to the respective software subsystems

Verification

  • CI Passes
  • Shuffleboard entries moved correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
starter ticket Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant