Render uncommitted IME text in bottom left corner #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inputting uncommitted text from an IME, this is now stored in a std::string imebuffer, just like keybuffer. It also enables extended editing events, so text longer than what fits in the standard editing event is also supported. This commit does not yet display the text onscreen.
This shows the uncommitted text in a box in the bottom left corner. This doesn't show the selection (defined by the start and length fields in the event) yet, but this is already much better than it was on its own, and I don't know how urgent the selection is since it's broken on Windows anyway.
Decided to implement it anyway since the broken behavior (selection length always being 0, at least on Windows) may get fixed later in SDL, so let's do it right in one go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
As a followup to #1041 and the discussion inside it, this PR now shows the current candidate text (the uncommitted text being edited in the IME) in a box in the bottom left corner. This visualizes the data from
SDL_TEXTEDITING[_EXT]events and makes it easier to input CJK text.So at first (before #1041) you couldn't see what you were doing at all, after #1041 you could at least see the candidate list making it much clearer what was going on but you couldn't see the uncommitted text, and now you can also see the uncommitted text.
Not much more to explain about it except for a demo video:
2024-08-02_03-22-30.mp4
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement