Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render uncommitted IME text in bottom left corner #1187

Merged
merged 3 commits into from
Aug 3, 2024

Commits on Aug 1, 2024

  1. Add buffer for IME editing events

    When inputting uncommitted text from an IME, this is now stored in a
    std::string imebuffer, just like keybuffer. It also enables extended
    editing events, so text longer than what fits in the standard editing
    event is also supported. This commit does not yet display the text
    onscreen.
    Daaaav committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7fed896 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Add IME text rendering

    This shows the uncommitted text in a box in the bottom left corner.
    This doesn't show the selection (defined by the start and length fields
    in the event) yet, but this is already much better than it was on its
    own, and I don't know how urgent the selection is since it's broken on
    Windows anyway.
    Daaaav committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f8656f7 View commit details
    Browse the repository at this point in the history
  2. Add selection background to IME rendering

    Decided to implement it anyway since the broken behavior (selection
    length always being 0, at least on Windows) may get fixed later in SDL,
    so let's do it right in one go.
    Daaaav committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f4e1152 View commit details
    Browse the repository at this point in the history