Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticketize current TODOs in codebase #50

Merged
merged 11 commits into from
Dec 22, 2023
Merged

Conversation

TheAfroOfDoom
Copy link
Owner

@TheAfroOfDoom TheAfroOfDoom commented Dec 22, 2023

Summary

closes #11

We compiled a handful of TODOs in the codebase so far that did not have an associated issue.

This PR creates an issue for each one and updates the TODO comment in the code to reference it.

Example:

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/1c7d513afea22f21e875fc48f7c413149b8fa3a3/datapacks/omega-flowey/data/entity/functions/hostile/omega-flowey/attack/friendliness-pellets/indicator/loop.mcfunction#L5-L9

#45

Effort was put in to ensure each issue had a reasonable description and could be picked up without too much more clarification.

Going forward, no TODOs will be merged without an associated issue.


Test plan

N/A

Reproducing in-game

N/A

Preview

each commit linked to the issues it created, go check them out if you're curious


Supplemental changes

N/A

@TheAfroOfDoom TheAfroOfDoom merged commit 5b15a24 into main Dec 22, 2023
1 check passed
@TheAfroOfDoom TheAfroOfDoom deleted the 11-ticketize-todos-0 branch December 22, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticketize TODOs - update them in codebase with number
1 participant