upgrade watch script and finalize .ajmodel auto-exporter
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidant19
force-pushed
the
8-aj-cli-export
branch
from
d477984 to
be2355d
Compare
- `yarn start` still works for me locally - `yarn start export` still works and doesn't change any auto-exported files except `load.mcfunction`s
- add errors if any process.env stuff is undefined
… we're not blindly exporting them over and over - included sample file in this commit, it will be gitignore'd next commit
- this is an incomplete commit, still need to update paths inside each `.ajmodel` file
- just using ctrl+shift+f
- shouldn't add any new texture files (it doesn't)
…tignore` that single file later
- should add parent commit's models to `white_dye.json` (it does)
- move custom textures from `omega-flowey/textures` to `omega-flowey/textures/custom` - point `.ajmodel` custom texture paths to new folder - see: https://discord.com/channels/154777837382008833/1196591704317370498/1196591704317370498
…xport script - e.g. `housefly_dev.ajmodel`
- redundant, but required for now just so they run - for maybe future improvement, see: - https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/settings/variables/actions - https://docs.github.com/en/actions/learn-github-actions/variables#creating-configuration-variables-for-a-repository
- nice to have for debugging etc. - also re-order `name` field before `hash` field
- how to run scripts and why - update new model creation steps to reflect ajexport script
TheAfroOfDoom
force-pushed
the
8-aj-cli-export-integration
branch
from
6a231a7 to
85675c9
Compare
- needed later for watch script
…-const` js files while running in blockbench script - move utils/consts to respective files
- used later for watch script to filter our logs from blockbench's kajillion logs
- clunky, slow - deleted + copied ENTIRE datapack/resourcepack directory when any single file changed to either - couldn't do more complex watching re: ajmodels with them - delete the "temp" mp3 files
- much faster copying on file changes - smart file deletion - watches model files and runs auto-exporter when necessary - recommends closing vanilla blockbench -- won't run auto-exporter if you have it open already when you start the watch script - log passthrough from auto exporter
…ll files instead of just resourcepack files
- just add `awaitWriteFinish` to datapack watcher - maybe to resourcepack watcher too? exporting the whole suite of ajmodels works for now though so nbd
TheAfroOfDoom
changed the title
TheAfroOfDoom
changed the title
.ajmodel auto-exporter
- its kinda janky - add script to still watch models as well with `yarn start watch.experimental` - update readme accordingly
|
@aidant19 i'm going to merge this now because i want to have the much faster watch script (regardless of the auto-exporter stuff) feel free to still review when you get a chance and i can still answer questions/make a separate PR to address your comments |
TheAfroOfDoom
changed the title
.ajmodel auto-exporter.ajmodel auto-exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #2 (23fdbcd)
closes #8 (46fe9b6)
closes #69 (9794a54)
closes #70 (46fe9b6)
This PR's primary purpose is to close #8.
We:
ajexport.jsscript for auto-exporting of AJ model files.gitignore.envfile support for dev-specific paths (crucial for these scripts to function smoothly).gitattributesfor nicer diffs in GitHub on old PRs with AJ export filesTest plan
Tested the script locally by running
yarn startand performing the following actions:Save without Formatting) -- exporter doesn't runfunction animated_java:bomb/summonReproducing
update local dependencies:
run the watch script:
Preview
Supplemental changes
white_dyeas a rig item:d9b18bb(#71)Copy Relative Pathuse/as separator always:71be143(#71)Setupin README to multiple collapsible sections:92aeb88(#71)