Mech-OffSeason-2024 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new file for new intake system removed unnecessary code - Atif
AG6GR
reviewed
Nov 7, 2023
| */ | ||
| public boolean handleAutoOuttakingState() { | ||
| if (!autoOuttakingTimerStarted) { | ||
| autoOuttakingTimerStarted = true; |
There was a problem hiding this comment.
I don't think you need autoOuttakingTimerStarted, you can just check if the timer value is equal to 0. Also if you need a new timer make a new timer, no need to share a timer with the other code.
|
|
||
| currentState = nextState(input); | ||
|
|
||
| currentTime = Timer.getFPGATimestamp(); |
There was a problem hiding this comment.
Do we still need the overrun detection code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Code for new intake design