Refactored Inputs, config.schema.json, and updated eiscp fork #80
Conversation
…r-merge # Conflicts: # README.md # config.schema.json # index.js # package.json
There was a problem hiding this comment.
Actually... after installing this pull request I am getting the following error when homebridge starts up. I rebuilt my config just in case it was causing issues.
[10/25/2020, 20:47:46] TypeError: Cannot read property 'some' of undefined
at /usr/local/lib/node_modules/homebridge-onkyo/index.js:808:24
at Array.filter ()
at OnkyoAccessory.addSources (/usr/local/lib/node_modules/homebridge-onkyo/index.js:807:38)
at OnkyoAccessory.setUp (/usr/local/lib/node_modules/homebridge-onkyo/index.js:160:37)
at new OnkyoAccessory (/usr/local/lib/node_modules/homebridge-onkyo/index.js:148:8)
at /usr/local/lib/node_modules/homebridge-onkyo/index.js:30:22
at Array.forEach ()
at OnkyoPlatform.createAccessories (/usr/local/lib/node_modules/homebridge-onkyo/index.js:29:13)
at new OnkyoPlatform (/usr/local/lib/node_modules/homebridge-onkyo/index.js:22:8)
at /usr/local/lib/node_modules/homebridge/src/server.ts:397:40
at Array.forEach ()
at Server.loadPlatforms (/usr/local/lib/node_modules/homebridge/src/server.ts:374:27)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:153:29)
at cli (/usr/local/lib/node_modules/homebridge/src/cli.ts:80:10)
at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)
at Module._compile (internal/modules/cjs/loader.js:1015:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1035:10)
at Module.load (internal/modules/cjs/loader.js:879:32)
at Function.Module._load (internal/modules/cjs/loader.js:724:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
at internal/main/run_main_module.js:17:47
|
Sorry guys, I was really busy caused by a covid-19 project that forced me to work literally every day since April this year. To give you some background info: I am authorized to merge commits on GitHub. To publish a new release on npmjs.org we need help from @ToddGreenfield ... or am I authorized? I can not remember, have to try. @ToddGreenfield to make things easier: in another project I added an npm token to my GitHub repository and enabled a GitHub action to push a new release to npm every time a new release was published on GitHub. |
|
@cbrandlehner You should be authorized to publish on npm for this package. Sorry guys, I just don't have time to maintain or assist. |
|
@ToddGreenfield good to know, thanks. ALL, if you need me to publish something, please let me know. |
|
hey there, any news regarding merging this PR? :) |
|
If this is what is needed, I can easily help. |
|
I would definitely use the DRX receiver support. Anything I can do to help please let me know. |
|
So is this the main repo now with 0.7.x, or is @ToddGreenfield's with 0.8.0? |
|
I'm curious if anyone figured this out |
|
Yes. It works. Just lots of trial and error. For the DRX 4 use the name DRX-4 input is bd. |
Before submitting your PR, please review the following checklist:
masterbranchDirectly addresses:
Merge back (ToddGreenfield & SoloWalker) projects into ToddGreenfield as looks like Todd is now actively maintaining original codebase (will cross post) solowalker27/homebridge-onkyo#13
Merge back fork (ToddGreenfield & SoloWalker) projects into ToddGreenfield as looks like Todd is now actively maintaining original codebase (will cross post) #70
Can't use TX-NR676 #75
require doesn't find eiscp-commands.json in HOOBS 3.2.4 #79
Request support for Integra (Onkyo) DRX-5 #77
Touches code around and thus potentially addresses (this should at least be looked at again after this):
#74
#72
#71
#68
#63
Manually merged my changes back in. Ran
npm testand fixed all the linting errors. Performed a sanity check with my own Onkyo and confirmed it's functioning properly. I tried to keep your styling changes as much as possible. I updated the input mapping to use yourinput_nameanddisplay_name. Did some cleanup along the way. Should hopefully be easier to review and more immediately testable.