-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Demon Aura #29
Open
cpaca
wants to merge
19
commits into
TraceLTRC:master
Choose a base branch
from
cpaca:DemonAura
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Demon Aura #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a straight copy of Magnet for DemonAura. Haven't touched any other files, only the two original files.
Pull commit from upstream
Pull commits from master branch
pull from upstream
Not gonna make a PR to upstream yet until I find out why I can't merge the book onto the item. Relatedly can't merge the magnet book onto a netherite pickaxe, so that's a thing.
I do this mostly so I can properly test the healing. I was testing with some larger xp orbs (so that the difference is more obvious) but of course to see the difference i need to have the HP to handle it. As a side effect, Zero can make an ARH boss that wears DAura armor and gains xp whenever a player within 100 blocks gains xp.
I must've missed getRecipe() when I first wrote it
Blocked on Paper API 1.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested:
Not Tested:
From what I can tell, it's always half a heart from a 1-xp orb (regardless of armor pieces), but larger orbs and more armor pieces gives more hp.
With a 100-xp orb and starting at 0 xp (and health boost 100):
One armor piece gives 7.5 hearts and 6.75-ish levels.
Four armor pieces gives 24(ish) hearts and 4.75-ish levels
Questions (these are in the code, in the TODOs, but I'll paste them here):