Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Demon Aura #29

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add Demon Aura #29

wants to merge 19 commits into from

Conversation

cpaca
Copy link
Contributor

@cpaca cpaca commented May 24, 2024

Tested:

  • Getting the book from the recipe
  • Getting the book from /holoitems acquire
  • Using either book to apply ench on armor
  • Having more armor pieces means getting more health.

Not Tested:

  • WorldGuard Integration

From what I can tell, it's always half a heart from a 1-xp orb (regardless of armor pieces), but larger orbs and more armor pieces gives more hp.
With a 100-xp orb and starting at 0 xp (and health boost 100):
One armor piece gives 7.5 hearts and 6.75-ish levels.
Four armor pieces gives 24(ish) hearts and 4.75-ish levels

Questions (these are in the code, in the TODOs, but I'll paste them here):

  • Do we want DAura on elytras? Both old and current implementations don't allow it.
  • What should the cost multiplier be? (For anvils)? I used 12, but that's copying from magnet
  • Should we assume 20 max hp or use Attribute.GENERIC_MAX_HP? The first one is what OldHoloItems uses, but the second one is what I used.

cpaca added 19 commits May 22, 2023 18:09
Just a straight copy of Magnet for DemonAura. Haven't touched any other files, only the two original files.
Pull commit from upstream
Pull commits from master branch
Not gonna make a PR to upstream yet until I find out why I can't merge the book onto the item. Relatedly can't merge the magnet book onto a netherite pickaxe, so that's a thing.
I do this mostly so I can properly test the healing. I was testing with some larger xp orbs (so that the difference is more obvious) but of course to see the difference i need to have the HP to handle it.

As a side effect, Zero can make an ARH boss that wears DAura armor and gains xp whenever a player within 100 blocks gains xp.
I must've missed getRecipe() when I first wrote it
@cpaca cpaca mentioned this pull request Jul 9, 2024
4 tasks
@dlee13
Copy link
Collaborator

dlee13 commented Jul 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants