Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved russian translation #22259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corporatemail12121
Copy link

I think this is better translation

Copy link
Contributor

coderabbitai bot commented Feb 21, 2025

Walkthrough

This pull request updates several Russian localization files within the Ghost repository. In the comments.json file, the time-related phrases have been shortened (e.g., from “{{amount}} часа(ов) назад” to “{{amount}} ч. назад”) and a name translation has been revised. Similarly, the ghost.json file sees changes in the greetings and registration messages, shifting to more formal language and adjusting prepositions and capitalization for improved clarity. The newsletter.json file updates the translation for "More like this" by shortening the phrase, while the portal.json file replaces a specific name translation with a generic term (“Полное имя”). Lastly, the search.json file modifies the spelling of "Tags" from “Теги” to “Тэги”. No alterations were made to the declarations of exported or public entities in these changes.

Possibly related PRs

Suggested labels

affects:i18n

Suggested reviewers

  • cathysarisky

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
ghost/i18n/locales/ru/newsletter.json (1)

11-11: Simplified "More like this" Translation
The key "More like this" has been changed from a more descriptive phrase to simply "Больше". Verify that this shorter version still conveys the intended meaning in the given UI context and does not lose important contextual cues.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 841fac7 and 92a615d.

📒 Files selected for processing (5)
  • ghost/i18n/locales/ru/comments.json (2 hunks)
  • ghost/i18n/locales/ru/ghost.json (1 hunks)
  • ghost/i18n/locales/ru/newsletter.json (1 hunks)
  • ghost/i18n/locales/ru/portal.json (1 hunks)
  • ghost/i18n/locales/ru/search.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • ghost/i18n/locales/ru/search.json
🔇 Additional comments (6)
ghost/i18n/locales/ru/ghost.json (3)

11-14: Enhanced Formality in Greetings and Instructions
Lines 11–14 update the casual "Hey there" greetings and related instructions to a more formal style, using "Здравствуйте," and clarifying the call-to-action. This change improves consistency and professionalism.


16-16: Refined Sign-off Message
The translation for "See you soon!" has been updated to "До скорой встречи!", which preserves a friendly tone while adhering to a more formal register.


19-21: Streamlined Sign In and Signup Confirmations
The modifications on lines 19 and 21 simplify the sign in and signup confirmation messages (e.g., "Войти в {{siteTitle}}" and "Спасибо за регистрацию в {{siteTitle}}!"). This concise phrasing should help avoid any potential ambiguity while maintaining formal language standards.

ghost/i18n/locales/ru/comments.json (2)

4-5: Concise Time Phrases Revision
The changes on lines 4 and 5 replace longer expressions like "{{amount}} часа(ов) назад" with the more concise "{{amount}} ч. назад" and "{{amount}} мин. назад". These shorter forms improve brevity while still informing the user; please confirm that this level of abbreviation is clear within context.


35-35: Standardized Generic Name Translation
Updating "Jamie Larson" to "Полное имя" ensures consistency with similar changes in other localization files. Double-check that this generic term is acceptable for all contexts and does not inadvertently remove essential context for users.

ghost/i18n/locales/ru/portal.json (1)

100-100: Consistent Name Translation Update
The key "Jamie Larson" has been updated to "Полное имя", matching the change in the comments localization file. This standardization streamlines the user interface; please ensure that the generic phrasing meets your localization guidelines across the application.

@@ -32,7 +32,7 @@
"Hidden for members": "Скрыто для участников",
"Hide": "Скрыть",
"Hide comment": "Скрыть комментарий",
"Jamie Larson": "Павел Бид",
"Jamie Larson": "Полное имя",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not going to be acceptable to the core dev team, where there are strong feelings about having the placeholder be a name, not the words "full name". So we want something that is recognizably a name. Ideally gender neutral, but that's not possible in some languages.

@@ -97,7 +97,7 @@
"In the event a permanent failure is received when attempting to send a newsletter, emails will be disabled on the account.": "В случае возникновения постоянной ошибки при попытке отправки рассылки — электронные письма будут отключены для данной учётной записи и указанного email адреса.",
"In your email client add {{senderEmail}} to your contacts list. This signals to your mail provider that emails sent from this address should be trusted.": "В вашем почтовом клиенте/приложении добавьте {{senderEmail}} в список контактов. Это скорее всего сигнализирует вашему почтовому провайдеру, что письмам, отправленным с этого адреса, следует доверять.",
"Invalid email address": "Неправильный email адрес",
"Jamie Larson": "Павел Бид",
"Jamie Larson": "Полное имя",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

@cathysarisky
Copy link
Contributor

Hey @hide-me , @kazanec18, @greatUzumaki , do you have time to review these proposed changes to the Russian Ghost translations? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants