mobile/1649 - feat:use context menu for information about unregistered username instead screen #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siepra
reviewed
Oct 19, 2023
| </View> | ||
| )} | ||
|
|
||
| {unregisteredUsername && username && ( |
There was a problem hiding this comment.
This is wrong. ContextMenu component was meant to be universal and here you introduced the explicit conditional. Use an existing hint prop or add another one if you really have to but make it "label", "description" or something like that. Also try to never render the contents of the component conditionally otherwise it'll soon get messy and overcomplicated
siepra
suggested changes
Oct 19, 2023
siepra
approved these changes
Oct 19, 2023
|
I changed the appearance 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: