-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile/1649 - feat:use context menu for information about unregistered username instead screen #1985
Merged
Merged
mobile/1649 - feat:use context menu for information about unregistered username instead screen #1985
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...ges/mobile/src/components/ContextMenu/menus/UnregisteredUsernameContextMenu.container.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import React, { FC } from 'react' | ||
import { useContextMenu } from '../../../hooks/useContextMenu' | ||
import { MenuName } from '../../../const/MenuNames.enum' | ||
import { ContextMenu } from '../ContextMenu.component' | ||
import { UnregisteredUsernameArgs } from '../ContextMenu.types' | ||
|
||
export const UnregisteredUsernameContextMenu: FC = () => { | ||
const title = 'Unregistered username' | ||
const usernameTakenContextMenu = useContextMenu<UnregisteredUsernameArgs>(MenuName.UnregisteredUsername) | ||
|
||
return ( | ||
<ContextMenu | ||
title={title} | ||
items={[]} | ||
{...usernameTakenContextMenu} | ||
unregisteredUsername | ||
username={usernameTakenContextMenu.username} | ||
/> | ||
) | ||
} |
31 changes: 0 additions & 31 deletions
31
packages/mobile/src/components/UserLabel/Unregistered/UnregisteredUsername.component.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. ContextMenu component was meant to be universal and here you introduced the explicit conditional. Use an existing hint prop or add another one if you really have to but make it "label", "description" or something like that. Also try to never render the contents of the component conditionally otherwise it'll soon get messy and overcomplicated