Remove Spring and switch to Zeitwerk #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an application of this size and the kind of hardware developers have access to, Spring is not required, ahead of an update to Rails 7, which does not include Spring by default, let's remove it here. We also want to run the Zeitwerk autoloader ahead of Rails 7 and we only appear to NOT be using it in the test environment, the reasoning for which also appears to relate to Spring?! The only Zeitwerk issue was in the GuidanceUrl spec, which was trying to load it from a non-existent module - not sure how this was ever working, but it is now!
mec
force-pushed
the
chore/switch-to-zeitwerk
branch
from
1df82c9 to
a5a824e
Compare
benshimmin
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an application of this size and the kind of hardware developers have
access to, Spring is not required, ahead of an update to Rails 7, which
does not include Spring by default, let's remove it here.
We also want to run the Zeitwerk autoloader ahead of Rails 7 and we only
appear to NOT be using it in the test environment, the reasoning for
which also appears to relate to Spring?!
The only Zeitwerk issue was in the GuidanceUrl spec, which was trying to
load it from a non-existent module - not sure how this was ever working,
but it is now!