Remove Spring and switch to Zeitwerk

CHANGELOG.md

@@ -4,6 +4,9 @@
 
 [Full changelog][unreleased]
 
+- Remove Spring from development
+- Switch to the Zeitwerk autoloader
+
 ## Release 153 - 2024-12-02
 
 [Full changelog][153]

Gemfile

@@ -67,9 +67,6 @@ group :development do
   gem "better_errors"
   gem "html2haml"
   gem "listen", ">= 3.0.5", "< 3.10"
-  gem "spring"
-  gem "spring-commands-rspec"
-  gem "spring-watcher-listen", "~> 2.1.0"
   gem "rails_layout"
   gem "web-console", ">= 3.3.0"
 end

Gemfile.lock

@@ -479,12 +479,6 @@ GEM
     slim (4.1.0)
       temple (>= 0.7.6, < 0.9)
       tilt (>= 2.0.6, < 2.1)
-    spring (4.2.1)
-    spring-commands-rspec (1.0.4)
-      spring (>= 0.9.1)
-    spring-watcher-listen (2.1.0)
-      listen (>= 2.7, < 4.0)
-      spring (>= 4)
     sprockets (4.2.1)
       concurrent-ruby (~> 1.0)
       rack (>= 2.2.4, < 4)
@@ -608,9 +602,6 @@ DEPENDENCIES
   sidekiq (~> 7)
   simplecov (~> 0.22.0)
   simplecov-lcov (~> 0.8.0)
-  spring
-  spring-commands-rspec
-  spring-watcher-listen (~> 2.1.0)
   standard
   strip_attributes
   tzinfo-data

bin/rails

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-load File.expand_path("spring", __dir__)
 APP_PATH = File.expand_path('../config/application', __dir__)
 require_relative '../config/boot'
 require 'rails/commands'

bin/rake

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-load File.expand_path("spring", __dir__)
 require_relative "../config/boot"
 require "rake"
 Rake.application.run

bin/rspec

@@ -1,10 +1,5 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-begin
-  load File.expand_path('spring', __dir__)
-rescue LoadError => e
-  raise unless e.message.include?('spring')
-end
 require 'bundler/setup'
 load Gem.bin_path('rspec-core', 'rspec')

config/environments/test.rb

@@ -10,14 +10,10 @@
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
-  config.cache_classes = !(defined?(Spring::Env) && Spring::Env.new.server_running?)
+  config.cache_classes = false
 
   config.action_view.cache_template_loading = true
 
-  # Prevent 'reloading is disabled' errors from Spring
-  # https://github.com/rails/spring/issues/598
-  config.autoloader = :classic
-
   # Do not eager load code on boot. This avoids loading your whole application
   # just for the purpose of running a single test. If you are using a tool that
   # preloads Rails for running tests, you may have to set it to true.

spec/models/guidance_url_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Activity::GuidanceUrl, type: :model do
+RSpec.describe GuidanceUrl, type: :model do
   describe "#to_s" do
     it "returns a url if one exists" do
       url = GuidanceUrl.new(:activity, :programme_status)