Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0주차/지나] 워크북 수정 제출합니다. #5

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[0주차/지나] 워크북 수정 제출합니다. #5

merged 2 commits into from
Sep 17, 2024

Conversation

jjiinaaa
Copy link

@jjiinaaa jjiinaaa commented Sep 17, 2024 •
edited
Loading

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?(중요)
  • 적절한 라벨을 설정하였나요?
  • 파트장에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?(매우 중요!)

📌 주안점

@jjiinaaa jjiinaaa requested a review from meoraeng September 17, 2024 05:17
@jjiinaaa jjiinaaa self-assigned this Sep 17, 2024
@jjiinaaa
Copy link
Author

키워드, 미션 추가하여 수정 제출합니다. 검토 부탁드립니다.

@jjiinaaa jjiinaaa linked an issue Sep 17, 2024 that may be closed by this pull request
Chapter00_깃&깃허브를 활용한 워크북 제출 #1
Open
meoraeng
meoraeng previously approved these changes Sep 17, 2024
View reviewed changes
Copy link

@meoraeng meoraeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

키워드 미션 모두 확인했습니다 수고하셨어요 :)

@jjiinaaa jjiinaaa changed the base branch from main to jina/main September 17, 2024 05:25
@jjiinaaa jjiinaaa dismissed meoraeng’s stale review September 17, 2024 05:25

The base branch was changed.

meoraeng
meoraeng approved these changes Sep 17, 2024
View reviewed changes
Copy link

@meoraeng meoraeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하.. 브랜치 설정을 잘못하셨군요
저도 놓쳤었네요 본인 브랜치 머지인지 확인 꼭 부탁드려요 ㅎㅎ

@jjiinaaa jjiinaaa merged commit fcfbfc1 into UMC-Inha:jina/main Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meoraeng meoraeng meoraeng approved these changes

Assignees

@jjiinaaa jjiinaaa

Labels
Chapter00 Keyword Mission
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chapter00_깃&깃허브를 활용한 워크북 제출
2 participants
@jjiinaaa @meoraeng