Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team 1 Projectiles merge to Main #128

Merged
merged 36 commits into from
Sep 9, 2023
Merged

Team 1 Projectiles merge to Main #128

merged 36 commits into from
Sep 9, 2023

Conversation

MiniSoda17
Copy link
Contributor

Hi there, please take a look at our code and let us know what you think! Here are the many changes we have added to the game within this pull request.

  • Engineer Bullets: Added a sleek design and animation for engineer bullets and slightly adjusted the spawning to fit the height of engineers
  • Mob King Balls: Added a new unique design and animation to Mob King projectiles. It is purple and big so very easy to differentiate from the other projectiles.
  • Slow Effect Projectile and Design: Implemented a projectile which upon impact will slow the entity down for a few seconds. It currently has a snowball design and animation.
  • Ricochet Projectile: Upon impact will bounce either up or down, continuing to deal damage across entities.
  • Piercing Projectile: Create a specific projectile that will not disappear on impact but rather keeps going and attacks all entities in its way.
  • Fireworks Projectile: Upon impact on an entity, will split into multiple projectiles and continue to keep splicing off into many projectiles
    The Slowing, ricochet, piercing, and fireworks projectiles are all currently spawning in the middle of the ForestGameArea and will be removed once the towers spawn them. Only there currently for testing purposes.

gregchan550 and others added 30 commits September 8, 2023 09:56
…that aoe effect will be applied only to entites with target layer
Copy link
Contributor

@Hasakev Hasakev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to get rid of the 3rd l in EngineerBulletsAnimationControlller.java (🤣)
Otherwise, LGTM, remember to add tests soon (ik we all are delaying this except for team 2)
Looking forward to the integration with the new turrets,

Copy link
Contributor

@Mohamad11Dab Mohamad11Dab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in good shape! For upcoming development sprints, however, I'd suggest implementing a component specifically for spawning projectiles. This could be designed as an event that gets triggered whenever an entity needs to fire a projectile. This approach would likely be more organized and efficient compared to having each entity individually handle projectile creation and launching. Overall, great job so far!

@MiniSoda17 MiniSoda17 merged commit edc4a94 into main Sep 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants