-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team 1 Projectiles merge to Main #128
Conversation
…that aoe effect will be applied only to entites with target layer
…023-studio-3 into Team-1--Projectiles
…023-studio-3 into collision-mechanisms
…ercombattask.java
…n target parameter toa pply single effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to get rid of the 3rd l in EngineerBulletsAnimationControlller.java (🤣)
Otherwise, LGTM, remember to add tests soon (ik we all are delaying this except for team 2)
Looking forward to the integration with the new turrets,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be in good shape! For upcoming development sprints, however, I'd suggest implementing a component specifically for spawning projectiles. This could be designed as an event that gets triggered whenever an entity needs to fire a projectile. This approach would likely be more organized and efficient compared to having each entity individually handle projectile creation and launching. Overall, great job so far!
Hi there, please take a look at our code and let us know what you think! Here are the many changes we have added to the game within this pull request.
The Slowing, ricochet, piercing, and fireworks projectiles are all currently spawning in the middle of the ForestGameArea and will be removed once the towers spawn them. Only there currently for testing purposes.