Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team 1 New Fire mobs and mob bug fixes #266

Merged
merged 21 commits into from
Oct 16, 2023
Merged

Team 1 New Fire mobs and mob bug fixes #266

merged 21 commits into from
Oct 16, 2023

Conversation

MiniSoda17
Copy link
Contributor

@MiniSoda17 MiniSoda17 commented Oct 15, 2023 •
edited
Loading

Bug Fixes

Projectiles

  • Fixed an issue where the burn and stun effects would stack on top of each other, creating an infinite amount of effects, and rendering the mobs useless instantly.

Mobs

  • Fixed an issue where splitting mobs would only split water slimes and not the actual mob that contained the splitting component
  • Fixed an issue where ranged mobs with the dodging component would not be able to shoot projectiles

New Features

Mobs

  • Fire Wizard: Wizard from the fire realm who deflects projectiles
  • Necromancer: A floating being, who uses his staff to deal damage up close to towers
  • Rocky: A fire rock that looks too cute but be warned, upon death will turn into 7 other Rocky creating a devastating attack.
  • Added sound effects to skeleton hit, coat attack, and archer arrow attack.

gregchan550 and others added 17 commits October 13, 2023 16:20
@gregchan550
created effect component and added it to all factories
de0dcbd
@gregchan550
added projectile effects component
5d80561
@freshc0w
Add various mobtypes with splitmoblings component
033694d
@MiniSoda17
Merge branch 'main' into Team-1-Mobs-Enhancement-variations
67ecbce
@cindyle1
Added fireWizard, splitRocky and necromanser to NPCFactory
40f8661
@cindyle1
Merge branch 'Team-1-Mobs-Enhancement-variations' of github.com:UQcss…
300e240 
…e3200/2023-studio-3 into Team-1-Mobs-Enhancement-variations
@cindyle1
Fixed merge conflict errors with split
36d4413
@MiniSoda17
Added bow and arrow sound
66719bf
@MiniSoda17
Merge branch 'Team-1-Mobs-Enhancement-variations' of https://github.c…
70685f9 
…om/UQcsse3200/2023-studio-3 into Team-1-Mobs-Enhancement-variations
@freshc0w
Alter dodging functionality so other tasks can be run simultaneously
27677df
@freshc0w
Merge branch 'Team-1-Mobs-Enhancement-variations' of https://github.c…
1c3a72a 
…om/UQcsse3200/2023-studio-3 into Team-1--Jono-True-Love
@MiniSoda17
Added new fire mobs to waves
f4b9a7c
@freshc0w
Fix moblings boundaries
264c5d6
@MiniSoda17
Merge branch 'Team-1-Mobs-Enhancement-variations' of https://github.c…
7b0d4c5 
…om/UQcsse3200/2023-studio-3 into Team-1-Mobs-Enhancement-variations
@MiniSoda17
Merge branch 'main' into Team-1-Mobs-Enhancement-variations
aedd08a
@MiniSoda17
Fixing Junit testing for mobs
a35c44d
@MiniSoda17
Added new mobs to new wave structure
3143751
@MiniSoda17 MiniSoda17 added this to the Sprint 4 milestone Oct 15, 2023
@MiniSoda17 MiniSoda17 self-assigned this Oct 15, 2023
Mohamad11Dab
Mohamad11Dab approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@Mohamad11Dab Mohamad11Dab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@The-AhmadAA The-AhmadAA merged commit 5d41139 into main Oct 16, 2023
2 checks passed
This was linked to issues Oct 17, 2023
[Team 1] Mob components and task bug fixes #236
Closed
[Team 1] New special feature mobs for waves #237
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohamad11Dab Mohamad11Dab Mohamad11Dab approved these changes

@The-AhmadAA The-AhmadAA The-AhmadAA approved these changes

@ryandmcneilly ryandmcneilly Awaiting requested review from ryandmcneilly

@Hasakev Hasakev Awaiting requested review from Hasakev

@SonjaMcNeilly SonjaMcNeilly Awaiting requested review from SonjaMcNeilly

@samsully samsully Awaiting requested review from samsully

@meganroxburgh meganroxburgh Awaiting requested review from meganroxburgh

@BlairCannon97 BlairCannon97 Awaiting requested review from BlairCannon97

Assignees

@MiniSoda17 MiniSoda17

@cindyle1 cindyle1

Labels
enhancement New feature or request feature sprint 4 team 1
Projects
2023 Studio 3 Project
Status: Done
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.

[Team 1] New special feature mobs for waves [Team 1] Mob components and task bug fixes
7 participants
@MiniSoda17 @The-AhmadAA @Mohamad11Dab @cindyle1 @gregchan550 @freshc0w @JSLLW