Team 7 - Fix code smells for the towers #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in TowerCombatTask
lenhatminh451
requested review from
shiv-0831,
Hasakev,
The-AhmadAA,
Mohamad11Dab,
Vishal-jodd,
ThivanW,
karthikeya-v and
SonjaMcNeilly
|
I'm going to sleep now, so if anyone sees many approvals from the reviewers, please help me merge this PR to prevent blocking newer PRs. Thank you! |
The-AhmadAA
reviewed
Oct 17, 2023
| private static final short TARGET1 = PhysicsLayer.BOSS; // The type of targets that the Engineer will detect. | ||
| private static final short TARGET2 = PhysicsLayer.XENO; | ||
| // private static final short TARGET1 = PhysicsLayer.BOSS; // The type of targets that the Engineer will detect. | ||
| // private static final short TARGET2 = PhysicsLayer.XENO; |
There was a problem hiding this comment.
Does the Bombship not target enemies, and is it handled somewhere else? why has this been commented out?
There was a problem hiding this comment.
This combat task still needs more functionalities; I just commented to check if it can fix the code smells and make it easier for us to continue to develop it later.
| // Define a set to keep track of occupied lanes | ||
| private static final Set<Integer> occupiedLanes = new HashSet<>(); | ||
| private static final int COMBAT_TASK_PRIORITY = 2; | ||
| private static final int WEAPON_TOWER_MAX_RANGE = 40; | ||
| private static final int TNT_TOWER_MAX_RANGE = 6; | ||
| private static final int TNT_TOWER_RANGE = 6; | ||
| private static final int TNT_KNOCK_BACK_FORCE = 10; | ||
| private static final String WALL_IMAGE = "images/towers/wall_tower.png"; | ||
| private static final String RESOURCE_TOWER = "images/towers/mine_tower.png"; | ||
| // private static final String WALL_IMAGE = "images/towers/wall_tower.png"; |
There was a problem hiding this comment.
Are these paths not necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to reduce the code smells in the tower's tasks, tests and configs. Almost all code smells have been fixed, but still some need to be rechecked on SonarCloud after merging with the main.