Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team 1 Mobs & Projectile Bug fixes #300

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Team 1 Mobs & Projectile Bug fixes #300

merged 11 commits into from
Oct 17, 2023

Conversation

MiniSoda17
Copy link
Contributor

Bug Fixes

  • Properly fixed a problem with Effect projectiles like burn, slow, and stun where they would infinitely stack on top of each other, doing insane amounts of damage or making the mob movement set to 0.
  • Fixing Dragon Knight dodging and collider issues once again, where it would get stuck between walls or not dodge in the correct direction.
  • Fixed a problem where mobs would sometimes not attack because the tower placed on them was too close.
  • Fixed a problem where the deflecting fire wizard would not die.

@MiniSoda17 MiniSoda17 added this to the Sprint 4 milestone Oct 17, 2023
@MiniSoda17 MiniSoda17 self-assigned this Oct 17, 2023
BlairCannon97
BlairCannon97 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@BlairCannon97 BlairCannon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This was linked to issues Oct 17, 2023
[Team 1] Mob components and task bug fixes #236
Closed
[Team 1] Fix projectile effects so that burn and slow dont stack #232
Closed
Hasakev
Hasakev approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Hasakev Hasakev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiniSoda17 MiniSoda17 merged commit 0943d57 into main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCannon97 BlairCannon97 BlairCannon97 approved these changes

@SonjaMcNeilly SonjaMcNeilly SonjaMcNeilly approved these changes

@Hasakev Hasakev Hasakev approved these changes

@The-AhmadAA The-AhmadAA Awaiting requested review from The-AhmadAA

@Mohamad11Dab Mohamad11Dab Awaiting requested review from Mohamad11Dab

@samsully samsully Awaiting requested review from samsully

@meganroxburgh meganroxburgh Awaiting requested review from meganroxburgh

Assignees

@MiniSoda17 MiniSoda17

Labels
sprint 4 task team 1
Projects
2023 Studio 3 Project
Status: Done
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.

[Team 1] Mob components and task bug fixes [Team 1] Fix projectile effects so that burn and slow dont stack
6 participants
@MiniSoda17 @Hasakev @SonjaMcNeilly @BlairCannon97 @gregchan550 @freshc0w