successfully inject map d3 into target/index.html (correct branch this time!) #35

lindsayplatt · 2018-01-04T19:21:44Z

Please see #34 for comments.

Merge branch 'master' of https://github.com/USGS-VIZLAB/vizstorm into d3 Conflicts: viz.yaml

jordansread · 2018-01-04T19:39:41Z

Wasn't I already pulling in D3 in vizstorm?

lindsayplatt · 2018-01-04T19:49:05Z

Hmm, not that I noticed. Where were you adding it?

jordansread · 2018-01-04T19:50:49Z

@lindsaycarr whoops, you are right, it isn't in here. But it is in https://github.com/USGS-VIZLAB/example/blob/master/viz.yaml#L190 and note that minified D3 is in the vizlab package, so you shouldn't need to commit that file.

aappling-usgs · 2018-01-04T20:13:46Z

viz.yaml

@@ -232,13 +232,22 @@ visualize:
    title: "SVG skeleton"
    alttext: "Beginning of the full storm SVG"
 publish:
+  -
+    mimetype: application/javascript


what's this line for?

whoops - forgot to delete it when I deleted the d3 library load

lindsayplatt · 2018-01-05T18:06:41Z

Ready to merge. Here's what the result of running vizmake() looks like:

jordansread · 2018-01-05T18:07:48Z

js/map.js

+    .attr( 'id', 'map' );
+
+// Add map features
+d3.json('../cache/state_map.geojson', function(us_data){


../cache isn't going to be available on CHS

.....WUT 🤦‍♀️ been operating under that assumption with this code.

Do you think I can push them to a target/data directory?

I think data that you want access to in target needs to be publish or otherwise exported.

aappling-usgs · 2018-01-05T18:11:48Z

Sweeeeet!

aappling-usgs · 2018-01-05T18:16:23Z

scripts/process/as_svg.R

@@ -1,266 +0,0 @@
-
-#' Sub mustache keys into text


i thought we still had uncertainty about whether the functions in this file can be used to keep the user experience speedy. if true, we may not be ready to remove this file already, though I know the functions are still on the other branch and in git history. what's your thinking on this now that you've been looking at vizstorm for a day, lindsay?

I went the route of saving everything as geojson, and using that within the D3 code. To be honest, I didn't really understand what this was, just thought it was needed when we handrolled SVG. I see what you mean, though - although we haven't experienced any slowness yet (but probably will when we get working with more data). I can revert so that the file remains. I probably got a little heavy-handed with my cleanup.

well...this gets at the question of where we draw the line between R and D3 - which is interesting. One thing, for example, is using R for the GIS side of things - I liked the original projection (and the flexibility that we can use whatever makes sense) over the one we'd need for d3.

For what it's worth - D3 should be able to do any projection. I'm just struggling with that right now.

yes, i think the R-D3 question is still open. makes sense to me to keep this file in here for now and think about how to optimize our use of the tools. i agree with lindsay that d3 projections should give us all the flexibility we'd need, but am also curious to eventually learn how much doing the projection in R might speed us up (or not). this may or may not be a question we answer in the next few weeks.

lindsayplatt · 2018-01-05T20:31:03Z

Not particularly happy with how I had to hack my way through getting JSON to be in target/, but here's something that works. I couldn't get the solution for the Hurricane Harvey viz linked in USGS-VIZLAB/vizlab#263 to work quite right, so this is a bit of a hybrid. remake won't allow me to use location: cache/state_map.geojson more than once, so I had to hack that a little. Since there is an issue in vizlab for making this easier, I'm not going to worry about it too much here.

lindsayplatt · 2018-01-05T20:50:38Z

Via Slack:

aappling: oof. a copy of your remake file with duplication locations might still be useful, but i'm starting to get an idea of what might be happening...and may not be able to fix it fast after all. hmm. i think this publish step is throwing a lot of wrenches around as currently implemented...

lcarr: I might revert those last changes, and keep using cache so that I can continue actually working on the viz and not battling vizlab. I can make an issue so that we don't forget this branch won't work on CHS until json files make it into target somewhere

Please see #37.

Lindsay Carr added 6 commits January 4, 2018 11:14

testing out js

3274405

merge upstream, resolve conflicts

650ed74

Merge branch 'master' of https://github.com/USGS-VIZLAB/vizstorm into d3 Conflicts: viz.yaml

add js as publisher + move js files

01de7d4

complete move of js file

6a81e59

inject js file into body of index

fb89adc

add d3 library as resource

028755c

use built-in d3 lib

5a73080

aappling-usgs reviewed Jan 4, 2018

View reviewed changes

Lindsay Carr added 8 commits January 4, 2018 14:15

fixing floating mimetype line

29c341a

nevermind - it was accidentally commited

597b287

floating dash

d56e040

add map js + process map data to geojson, not svg

303f205

remove svg creation code

afe5509

increase chart width

7f4f7d9

remove commented code + edit comments

59c4e21

change spatial projection

dc632c1

lindsayplatt changed the title ~~successfully inject dummy d3 into target/index.html (correct branch this time!)~~ successfully inject map d3 into target/index.html (correct branch this time!) Jan 5, 2018

jordansread reviewed Jan 5, 2018

View reviewed changes

aappling-usgs reviewed Jan 5, 2018

View reviewed changes

reinstate as_svg.R

9fbb718

lindsayplatt mentioned this pull request Jan 5, 2018

projections w/ D3 #36

Closed

Lindsay Carr added 2 commits January 5, 2018 14:27

hack to get geojson in target

6b40412

remake won't allow duplication location tags

cf79e4c

lindsayplatt mentioned this pull request Jan 5, 2018

d3 branch won't work on CHS #37

Open

revert attempt to export geojson to target

d41f258

aappling-usgs merged commit ab43f11 into USGS-VIZLAB:d3 Jan 5, 2018

aappling-usgs mentioned this pull request Jan 14, 2018

use vizlab's export/publish to put data in target/data #44

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

successfully inject map d3 into target/index.html (correct branch this time!) #35

successfully inject map d3 into target/index.html (correct branch this time!) #35

lindsayplatt commented Jan 4, 2018

jordansread commented Jan 4, 2018

lindsayplatt commented Jan 4, 2018

jordansread commented Jan 4, 2018

aappling-usgs Jan 4, 2018

lindsayplatt Jan 4, 2018

lindsayplatt commented Jan 5, 2018

jordansread Jan 5, 2018

lindsayplatt Jan 5, 2018

jordansread Jan 5, 2018

lindsayplatt Jan 5, 2018

aappling-usgs commented Jan 5, 2018

aappling-usgs Jan 5, 2018

lindsayplatt Jan 5, 2018

jordansread Jan 5, 2018

lindsayplatt Jan 5, 2018

aappling-usgs Jan 5, 2018

lindsayplatt commented Jan 5, 2018

lindsayplatt commented Jan 5, 2018 •

edited

Loading

successfully inject map d3 into target/index.html (correct branch this time!) #35

successfully inject map d3 into target/index.html (correct branch this time!) #35

Conversation

lindsayplatt commented Jan 4, 2018

jordansread commented Jan 4, 2018

lindsayplatt commented Jan 4, 2018

jordansread commented Jan 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lindsayplatt commented Jan 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aappling-usgs commented Jan 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lindsayplatt commented Jan 5, 2018

lindsayplatt commented Jan 5, 2018 • edited Loading

lindsayplatt commented Jan 5, 2018 •

edited

Loading