bg of filter changes when filter is selected

[justjaiom]

Overview

List the GitHub issues containing the issues relevant to this pull request.

fixed the proposal: "When a filter has been selected, make the filter box have a darker shade / color"

What Changed

I changed filters.txt, specifically the class names in the form control. I edited al three form controls so that a darker grey is presented when a filter is applied.

Other Notes

I used a dark grey (grey-900) for the dark theme, but if it doesn't fit into the color theme or the design, let me know so i can change it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
utd-trends	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 11:39pm

[TyHil]

I think for the semester filter, it might be better if the color is different when select all is not checked, like when chosenSessions.length !== academicSessions.length. This way the default is for it to be the normal color, and when you deselect a session it changes color

[AbhiramTadepalli]

This doesn't work well in dark mode fyi

[justjaiom]

This doesn't work well in dark mode fyi

This doesn't work well in dark mode fyi

[AbhiramTadepalli]

1. should "All Semesters" be highlighted as selected? It does bring attention to the semester filter, but it also is the default state
2. What do we think about the tooltip for semester
3. until you click something else, even on scroll, the tooltip on the filter remains

[TyHil]

1. I think current behavior is good: highlight when not at default. but nitpick it should also be highlighted when none are selected
2. tbh i don't see the point. i think the tooltips should describe that its a filter and what you're filtering on like "Filter by minimum letter grade across course sections"
3. i think that's probably an inevitable accessibility thing

[AbhiramTadepalli]

1. I think current behavior is good: highlight when not at default. but nitpick it should also be highlighted when none are selected

[AbhiramTadepalli]

2. tbh i don't see the point. i think the tooltips should describe that its a filter and what you're filtering on like "Filter by minimum letter grade across course sections"

rn it's dynamic so if something is selected the tag changes

[TyHil]

rn it's dynamic so if something is selected the tag changes

oh ok i see. but i can already see that information in the dropdown without hovering

[AbhiramTadepalli]

Great!

[TyHil]

all good!