Only filter files in directories starting with . #16784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac builds were missing some definitions, which happened because there was a . in the directory. The reason why we filtered these in the first place was because Apple doesn't notarize/sign an App correctly if the directory starts with a . e.q.: .dylibs in scipy and shapely. Made the filtering less aggressive Contributes to CURA-11014
Contributes to CURA-11014
|
Folder names in the quality folder renaming done so that in mac while building it doesn't skip adding it to the package. |
This reverts commit d8b5b26.
This reverts commit f806a61.
A new Linter subclass - 'Directory' has been created and integrated into the linting process to handle directory naming conventions, specifically for MacOS. MacOS has issues when signing and notarizing directories with '.' in their names. The new class will trigger an 'Error' level diagnostic if this convention is violated. The linter will become a required check with this update, as its new check configuration was added to '.printer-linter'. The version number in 'pyproject.toml' was also incremented to reflect these changes. Contributes to CURA-11014
Contributes to CURA-11014
rburema
reviewed
Sep 22, 2023
| yield Diagnostic( | ||
| file = self._file, | ||
| diagnostic_name = "diagnostic-resources-macos-app-directory-name", | ||
| message = f"Directory name containing a `.` not allowed {self._file.suffix}, rename directory containing this file e.q: `_`", |
There was a problem hiding this comment.
We should maybe mention that this is specifically for MacOS. Less questions from implementers that way ;-)
rburema
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mac builds were missing some definitions, which happened because there was
a . in the directory. The reason why we filtered these in the first place
was because Apple doesn't notarize/sign an App correctly if the directory
starts with a . e.q.: .dylibs in scipy and shapely.
Renamed the resources folder containing a
.with an_Added a new diagnostic check to the printer-linter which will diagnose if the directory contains a
.Fixes #16007
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: