Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only filter files in directories starting with . #16784

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Only filter files in directories starting with . #16784

merged 7 commits into from
Sep 22, 2023

Commits on Sep 21, 2023

  1. Only filter files in directories starting with . 

    Mac builds were missing some definitions, which happened because there was
a . in the directory. The reason why we filtered these in the first place
was because Apple doesn't notarize/sign an App correctly if the directory
starts with a . e.q.: .dylibs in scipy and shapely.

Made the filtering less aggressive

Contributes to CURA-11014
    @jellespijker
    jellespijker committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f806a61 View commit details
    Browse the repository at this point in the history

  2. MacOS App doesn't like dots 

    Contributes to CURA-11014
    @jellespijker
    jellespijker committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d8b5b26 View commit details
    Browse the repository at this point in the history

  3. . in folder names changed to _ 

    CURA-11014
    @saumyaj3
    saumyaj3 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    75b8a18 View commit details
    Browse the repository at this point in the history

  4. Revert "MacOS App doesn't like dots" 

    This reverts commit d8b5b26.
    @jellespijker
    jellespijker committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0fe10b4 View commit details
    Browse the repository at this point in the history

  5. Revert "Only filter files in directories starting with ." 

    This reverts commit f806a61.
    @jellespijker
    jellespijker committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d5f4bff View commit details
    Browse the repository at this point in the history

  6. Add MacOS directory naming linting 

    A new Linter subclass - 'Directory' has been created and integrated into the linting process to handle directory naming conventions, specifically for MacOS. MacOS has issues when signing and notarizing directories with '.' in their names. The new class will trigger an 'Error' level diagnostic if this convention is violated. The linter will become a required check with this update, as its new check configuration was added to '.printer-linter'. The version number in 'pyproject.toml' was also incremented to reflect these changes.

Contributes to CURA-11014
    @jellespijker
    jellespijker committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b401ece View commit details
    Browse the repository at this point in the history

  7. removed debugging statement 

    Contributes to CURA-11014
    @jellespijker
    jellespijker committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    658f270 View commit details
    Browse the repository at this point in the history