-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Top/Bottom Layers formula #19968
base: main
Are you sure you want to change the base?
Conversation
Set global Top and Bottom Layer values to match previous Ultimaker defaults.
Removed Top and Bottom Layers values. With global defaults updated it is no longer required to re-set them.
Restore missing commas. Going to need those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
@@ -16,7 +16,6 @@ | |||
{ | |||
"acceleration_layer_0": { "value": "acceleration_topbottom" }, | |||
"acceleration_travel_enabled": { "value": false }, | |||
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" }, | |||
"bridge_enable_more_layers": { "value": false }, | |||
"bridge_fan_speed": { "value": "cool_fan_speed_max" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding cool_fan_speed_max with the same value (value: 100) as defined in parent definition: fdmprinter
"support_xy_distance_overhang": { "value": "0.2" }, | ||
"support_z_distance": { "value": "0" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding support_xy_distance_overhang with the same value (value: 0.2) as defined in parent definition: fdmprinter
"support_xy_distance_overhang": { "value": "0.2" }, | |
"support_z_distance": { "value": "0" }, | |
"support_z_distance": { "value": "0" }, |
@@ -16,7 +16,6 @@ | |||
{ | |||
"acceleration_layer_0": { "value": "acceleration_topbottom" }, | |||
"acceleration_travel_enabled": { "value": false }, | |||
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" }, | |||
"bridge_enable_more_layers": { "value": false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting bridge_enable_more_layers is still experimental and should not be used in default profiles
@@ -16,7 +16,6 @@ | |||
{ | |||
"acceleration_layer_0": { "value": "acceleration_topbottom" }, | |||
"acceleration_travel_enabled": { "value": false }, | |||
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" }, | |||
"bridge_enable_more_layers": { "value": false }, | |||
"bridge_fan_speed": { "value": "cool_fan_speed_max" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting bridge_fan_speed is still experimental and should not be used in default profiles
@@ -16,7 +16,6 @@ | |||
{ | |||
"acceleration_layer_0": { "value": "acceleration_topbottom" }, | |||
"acceleration_travel_enabled": { "value": false }, | |||
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" }, | |||
"bridge_enable_more_layers": { "value": false }, | |||
"bridge_fan_speed": { "value": "cool_fan_speed_max" }, | |||
"bridge_fan_speed_2": { "value": "cool_fan_speed_min" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting bridge_fan_speed_2 is still experimental and should not be used in default profiles
Description
Replaces the global default values for both Top Layers and Bottom Layers with those found in the Ultimaker definition. This removes the unexpected behaviour where a model will become solid Bottom Layers instead of Infill when setting the Infill Density to 100%, allowing all appropriate Infill properties - speed, line width, layer thickness, extruder, etc - to be applied where they are supposed to be. This also prevents any interference with the Top Surface Skin Layers feature by no longer setting the Top Layers to zero.
Removes the corresponding declarations from the Ultimaker definition as they now match the inherited values.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: