Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Top/Bottom Layers formula #19968

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Asterchades
Copy link
Collaborator

Description

Replaces the global default values for both Top Layers and Bottom Layers with those found in the Ultimaker definition. This removes the unexpected behaviour where a model will become solid Bottom Layers instead of Infill when setting the Infill Density to 100%, allowing all appropriate Infill properties - speed, line width, layer thickness, extruder, etc - to be applied where they are supposed to be. This also prevents any interference with the Top Surface Skin Layers feature by no longer setting the Top Layers to zero.

Removes the corresponding declarations from the Ultimaker definition as they now match the inherited values.

Type of change

  • Printer definition file(s)

How Has This Been Tested?

  • With an updated local configuration matching the new settings, Cura behaves as expected.

Test Configuration:

  • Microsoft Windows 11 Pro (build 22631.4317)
  • AMD Ryzen 5 5800X3D
  • 32GB RAM
  • NVidia GeForce RTX 3080 10GB

Checklist:

Set global Top and Bottom Layer values to match previous Ultimaker defaults.
Removed Top and Bottom Layers values. With global defaults updated it is no longer required to re-set them.
Restore missing commas. Going to need those.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Nov 28, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@@ -16,7 +16,6 @@
{
"acceleration_layer_0": { "value": "acceleration_topbottom" },
"acceleration_travel_enabled": { "value": false },
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" },
"bridge_enable_more_layers": { "value": false },
"bridge_fan_speed": { "value": "cool_fan_speed_max" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding cool_fan_speed_max with the same value (value: 100) as defined in parent definition: fdmprinter

Comment on lines 131 to 132
"support_xy_distance_overhang": { "value": "0.2" },
"support_z_distance": { "value": "0" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_xy_distance_overhang with the same value (value: 0.2) as defined in parent definition: fdmprinter

Suggested change
"support_xy_distance_overhang": { "value": "0.2" },
"support_z_distance": { "value": "0" },
"support_z_distance": { "value": "0" },

@@ -16,7 +16,6 @@
{
"acceleration_layer_0": { "value": "acceleration_topbottom" },
"acceleration_travel_enabled": { "value": false },
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" },
"bridge_enable_more_layers": { "value": false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_enable_more_layers is still experimental and should not be used in default profiles

@@ -16,7 +16,6 @@
{
"acceleration_layer_0": { "value": "acceleration_topbottom" },
"acceleration_travel_enabled": { "value": false },
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" },
"bridge_enable_more_layers": { "value": false },
"bridge_fan_speed": { "value": "cool_fan_speed_max" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_fan_speed is still experimental and should not be used in default profiles

@@ -16,7 +16,6 @@
{
"acceleration_layer_0": { "value": "acceleration_topbottom" },
"acceleration_travel_enabled": { "value": false },
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" },
"bridge_enable_more_layers": { "value": false },
"bridge_fan_speed": { "value": "cool_fan_speed_max" },
"bridge_fan_speed_2": { "value": "cool_fan_speed_min" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_fan_speed_2 is still experimental and should not be used in default profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant