Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Top/Bottom Layers formula #19968

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −6
Open

Update Top/Bottom Layers formula #19968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eec792d
Update fdmprinter.def.json
Asterchades Nov 28, 2024
e0cda11
Update ultimaker.def.json
Asterchades Nov 28, 2024
cabd426
Update fdmprinter.def.json
Asterchades Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/definitions/fdmprinter.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,7 @@
"maximum_value": "999999",
"type": "int",
"minimum_value_warning": "2",
"value": "0 if infill_sparse_density == 100 else math.ceil(round(top_thickness / resolveOrValue('layer_height'), 4))",
"value": "math.ceil(round(top_thickness / resolveOrValue('layer_height'), 4))",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
}
Expand Down Expand Up @@ -1625,7 +1625,7 @@
"default_value": 6,
"maximum_value": "999999",
"type": "int",
"value": "999999 if infill_sparse_density == 100 and not magic_spiralize else math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))",
"value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
Expand Down Expand Up @@ -9193,4 +9193,4 @@
}
}
}
}
}
4 changes: 1 addition & 3 deletions resources/definitions/ultimaker.def.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
{
"acceleration_layer_0": { "value": "acceleration_topbottom" },
"acceleration_travel_enabled": { "value": false },
"bottom_layers": { "value": "math.ceil(round(bottom_thickness / resolveOrValue('layer_height'), 4))" },
"bridge_enable_more_layers": { "value": false },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_enable_more_layers is still experimental and should not be used in default profiles

"bridge_fan_speed": { "value": "cool_fan_speed_max" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding cool_fan_speed_max with the same value (value: 100) as defined in parent definition: fdmprinter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_fan_speed is still experimental and should not be used in default profiles

"bridge_fan_speed_2": { "value": "cool_fan_speed_min" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_fan_speed_2 is still experimental and should not be used in default profiles

Expand Down Expand Up @@ -131,7 +130,6 @@
"support_wall_count": { "value": "1 if support_structure == 'tree' else 0" },
"support_xy_distance_overhang": { "value": "0.2" },
"support_z_distance": { "value": "0" },
Comment on lines 131 to 132
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding support_xy_distance_overhang with the same value (value: 0.2) as defined in parent definition: fdmprinter

Suggested change
"support_xy_distance_overhang": { "value": "0.2" },
"support_z_distance": { "value": "0" },
"support_z_distance": { "value": "0" },

"top_layers": { "value": "math.ceil(round(top_thickness / resolveOrValue('layer_height'), 4))" },
"wall_0_material_flow_layer_0": { "value": "1.10 * material_flow_layer_0" },
"wall_thickness": { "value": "wall_line_width_0 + wall_line_width_x" },
"wall_x_material_flow_layer_0": { "value": "0.95 * material_flow_layer_0" },
Expand All @@ -141,4 +139,4 @@
"z_seam_relative": { "value": "True" },
"zig_zaggify_support": { "value": true }
}
}
}
Loading