Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-10994] Translations for 5.5.x #908

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

rburema
Copy link
Member

@rburema rburema commented Sep 26, 2023

See also frontend PR: Ultimaker/Cura#16829

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Unit Test Results

0 tests   - 2 406   0 ✔️  - 2 391   0s ⏱️ -26s
0 suites  -        1   0 💤  -      15 
0 files    -        1   0 ±       0 

Results for commit 4f3c82d. ± Comparison against base commit b810713.

♻️ This comment has been updated with latest results.

Just translate them _before_ we push them into the stack, which is both lightweight, and gives the maximum control of translations to the implementor (without making it any more difficult). Note that the frontend'll need to be changed as well for this.

done as part of CURA-10994
done as part of CURA-10994
@casperlamboo casperlamboo marked this pull request as ready for review October 11, 2023 08:33
@casperlamboo casperlamboo merged commit 66907d2 into 5.5 Oct 11, 2023
9 of 12 checks passed
@casperlamboo casperlamboo deleted the CURA-10994_translations_v5p5 branch October 11, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants