Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use word-sized params in scd4x self-calibration #660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dankamongmen
Copy link

@dankamongmen dankamongmen commented Oct 10, 2024

scd4x self-calibration passes bool and bool* to execute_cmd(), but this function eventually swaps its 16-bit argument words. a bool is typically represented by a single byte, and thus the swap() reads and writes past the end of the storage, canonical undefined behavior. instead, copy the bool to a local uint16_t, and pass that as the single word. in the get() variant, copy the uint16_t back to the bool on success.

scd4x self-calibration passes bool and bool* to execute_cmd(),
but this function eventually swaps its 16-bit argument words.
a bool is typically represented by a single byte, and thus
the swap() reads and writes past the end of the storage,
canonical undefined behavior. instead, copy the bool to a
local uint16_t, and pass that as the single word. in the
get() variant, copy the uint16_t back to the bool on success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant