Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use word-sized params in scd4x self-calibration #660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use word-sized params in scd4x self-calibration #660

wants to merge 1 commit into from

Commits on Oct 10, 2024

  1. use word-sized params in scd4x self-calibration 

    scd4x self-calibration passes bool and bool* to execute_cmd(),
but this function eventually swaps its 16-bit argument words.
a bool is typically represented by a single byte, and thus
the swap() reads and writes past the end of the storage,
canonical undefined behavior. instead, copy the bool to a
local uint16_t, and pass that as the single word. in the
get() variant, copy the uint16_t back to the bool on success.
    @dankamongmen
    dankamongmen committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1880bbb View commit details
    Browse the repository at this point in the history