Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minkowski multiplication for semigroups, monoids, and commutative monoids #1309

Merged
merged 28 commits into from
Feb 10, 2025
Merged

Minkowski multiplication for semigroups, monoids, and commutative monoids #1309

merged 28 commits into from
Feb 10, 2025

Conversation

lowasser
Copy link
Contributor

@lowasser lowasser commented Feb 9, 2025

No description provided.

@lowasser lowasser mentioned this pull request Feb 9, 2025
Closed
@lowasser
Copy link
Contributor Author

My intention had been to continue using that style until a decision got made on #1306. I can inline the claim variants until that happens, though.

lowasser and others added 12 commits February 10, 2025 08:27
@lowasser
Copy link
Contributor Author

(I misread the earlier comment that they are okay for now, and I'm leaving them in.)

@fredrik-bakke
Copy link
Collaborator

It doesn't look like all of my suggestions got implemented, @lowasser. Do you still have unpushed changes locally?

@lowasser
Copy link
Contributor Author

Some very strange things kept happening when I tried to commit the code review suggestions, and things kept vanishing. I will go through manually.

fredrik-bakke
fredrik-bakke approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one change request that is still pending, but other than that this PR looks ready to be merged to me.

@lowasser
Copy link
Contributor Author

Committed that change.

@fredrik-bakke fredrik-bakke merged commit 095a6f6 into UniMath:master Feb 10, 2025
4 checks passed
@lowasser lowasser deleted the minkowski-sum-semigroup branch February 10, 2025 21:55
@fredrik-bakke fredrik-bakke mentioned this pull request Feb 11, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechStep VojtechStep VojtechStep left review comments

@fredrik-bakke fredrik-bakke fredrik-bakke approved these changes

Assignees
No one assigned
Labels
group-theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lowasser @VojtechStep @fredrik-bakke