Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark needed, but marked as unused, imports and remove unused imports #3020

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Mark needed, but marked as unused, imports and remove unused imports #3020

merged 4 commits into from
Nov 22, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 25, 2024 •
edited
Loading

No description provided.

@johannaengland johannaengland self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 991 0 12.78s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Test results

    9 files      9 suites   8m 35s ⏱️
2 139 tests 2 139 ✅ 0 💤 0 ❌
4 017 runs  4 017 ✅ 0 💤 0 ❌

Results for commit afbe765.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (27b12b5) to head (afbe765).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3020   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         605      605           
  Lines       43687    43688    +1     
  Branches       48       48           
=======================================
+ Hits        26383    26384    +1     
  Misses      17292    17292           
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@lunkwill42
Copy link
Member

I could add that whenever you see pylint disables like

# pylint: disable=W0611

This is the same thing. Pylint's W0611 is equivalent to ruff's F401

@johannaengland johannaengland mentioned this pull request Sep 25, 2024
Open
lunkwill42
lunkwill42 requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything else I should comment on?

python/nav/bin/navcheckservice.py Outdated Show resolved Hide resolved
python/nav/smsd/uninettmaildispatcher.py Outdated Show resolved Hide resolved
python/nav/asyncdns.py Outdated Show resolved Hide resolved
lunkwill42
lunkwill42 requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I think we could probably use the __all__ in more places where seemingly "unused" imports are there to be importable from other modules.

python/nav/ipdevpoll/shadows/__init__.py Outdated Show resolved Hide resolved
@johannaengland johannaengland mentioned this pull request Sep 27, 2024
Open
@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch from f4eaae2 to 2a2c093 Compare September 27, 2024 09:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch from 2a2c093 to e0fed99 Compare November 15, 2024 10:10
lunkwill42
lunkwill42 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go :)

@johannaengland johannaengland force-pushed the cleanup/add-noqa-to-necessary-unused-imports branch from e0fed99 to afbe765 Compare November 22, 2024 09:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johannaengland johannaengland changed the title Add noqa to necessary, but market as unused, imports Mark needed, but marked as unused, imports and remove unused imports Nov 22, 2024
@johannaengland johannaengland merged commit 518b252 into master Nov 22, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the cleanup/add-noqa-to-necessary-unused-imports branch November 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels
cleanup help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannaengland @lunkwill42