Add class representing a Div #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 32s ⏱️ Results for commit 64ec82a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
- Coverage 60.39% 60.39% -0.01%
==========================================
Files 605 605
Lines 43704 43709 +5
Branches 48 48
==========================================
+ Hits 26396 26398 +2
- Misses 17296 17299 +3
Partials 12 12 ☔ View full report in Codecov by Sentry. |
stveit
commented
Nov 8, 2024
stveit
commented
Nov 11, 2024
johannaengland
requested changes
Nov 11, 2024
stveit
force-pushed
the
uncrispify/add-div-class
branch
from
a730cb4
to
17076c0
Compare
johannaengland
approved these changes
Nov 12, 2024
Just a blank div that can be customized with classes and stuff. replaces crispyforms Div.
stveit
force-pushed
the
uncrispify/add-div-class
branch
from
17076c0
to
64ec82a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a blank div as replacement for the crispyforms
Divclass.Part of the uncrispyfication (#2794).
Arnold
ManualDetentionFormandDetentionProfileFormuseDivs with a specific class added to itto make it hide and reappear. Tried to recreate the effect using widget manipulation, changes to
arnold.scssetc etc..Using a
FormRowworked the best, but still wasnt perfect (it messed up the margins for some reason). As aFormRowis just a div with the "row" css class added to it, it seems reasonable to have a class for blank div that you can do whatever you want with.