Make css_classes argument optional for FormRow
#3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 22s ⏱️ Results for commit fc81e8a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3187 +/- ##
=======================================
Coverage 60.39% 60.39%
=======================================
Files 605 605
Lines 43705 43705
Branches 48 48
=======================================
Hits 26394 26394
Misses 17299 17299
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
The template changes need some work. Testing on Portadmin search form: before: after: |
stveit
approved these changes
Nov 13, 2024
johannaengland
force-pushed
the
refactor/form-row-optional-css-classes
branch
from
94d5b2b
to
92fd39b
Compare
johannaengland
force-pushed
the
refactor/form-row-optional-css-classes
branch
from
92fd39b
to
fc81e8a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3169. This makes it a bit tidier.